[jira] [Commented] (PARQUET-518) Review usages of size_t and unsigned integers generally per Google style guide

["Aliaksei Sandryhaila (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140875#comment-15140875 ] 

Aliaksei Sandryhaila commented on PARQUET-518:
----------------------------------------------

It will be nice to enforce explicit casting between integers with static_cast. We can easily check for implicit casts with compiler flags.

We use STL containers, and those rely on size_t (for example, size() method). Since size_t is portable, IMO it's ok to keep using it.

> Review usages of size_t and unsigned integers generally per Google style guide
> ------------------------------------------------------------------------------
>
>                 Key: PARQUET-518
>                 URL: https://issues.apache.org/jira/browse/PARQUET-518
>             Project: Parquet
>          Issue Type: Improvement
>          Components: parquet-cpp
>            Reporter: Wes McKinney
>            Priority: Minor
>
> The Google style guide recommends generally avoiding unsigned integers for the bugs they can silently introduce. 
> https://google.github.io/styleguide/cppguide.html#Integer_Types



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)