[jira] [Commented] (KAFKA-203) Improve Kafka internal metrics

["Chris Burroughs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417643#comment-13417643 ] 

Chris Burroughs commented on KAFKA-203:
---------------------------------------

I also have metrics all over the place in production as well.

The scala compatibility problem only exists if we use metrics-scala, which is just a  pretty wrapper around the pure java stuff http://metrics.codahale.com/manual/scala/.  If we don't use that all of the dependency complications go away.  Is using the java interface palatable?

For mx4j we made it optional on the classpath.  We can follow the same pattern with metrics reporters to minimize dependency complications for kafak-as-library.

Off Topic:  Json is totally human readable https://addons.mozilla.org/EN-us/firefox/addon/jsonview/
                
> Improve Kafka internal metrics
> ------------------------------
>
>                 Key: KAFKA-203
>                 URL: https://issues.apache.org/jira/browse/KAFKA-203
>             Project: Kafka
>          Issue Type: New Feature
>          Components: core
>            Reporter: Jay Kreps
>            Assignee: Jay Kreps
>
> Currently metrics in kafka are using old-school JMX directly. This makes adding metrics a pain. It would be good to do one of the following:
> 1. Convert to Coda Hale's metrics package (https://github.com/codahale/metrics)
> 2. Write a simple metrics package
> The new metrics package should make metrics easier to add and work with and package up the common logic of keeping windowed gauges, histograms, counters, etc. JMX should be just one output of this.
> The advantage of the Coda Hale package is that it exists so we don't need to write it. The downsides are (1) introduces another client dependency which causes conflicts, and (2) seems a bit heavy on design. The good news is that the metrics-core package doesn't seem to bring in a lot of dependencies which is nice, though the scala wrapper seems to want scala 2.9. I am also a little skeptical of the approach for histograms--it does sampling instead of bucketing though that may be okay.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira