[PR] Remove unused approved steps field from MCP workflow request [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu opened a new pull request, #39317:
URL: https://github.com/apache/shardingsphere/pull/39317

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove unused approved steps field from MCP workflow request [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu merged PR #39317:
URL: https://github.com/apache/shardingsphere/pull/39317


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove unused approved steps field from MCP workflow request [shardingsphere]

["terrymanu (via GitHub)" <gi...@apache.org>]

terrymanu commented on PR #39317:
URL: https://github.com/apache/shardingsphere/pull/39317#issuecomment-5158983951

   ### Result
   
   **Review Result: Mergeable**
   
   The latest head fixes all previously confirmed issues, and no new code-correctness blockers were found.
   
   ### Evidence
   
   - Reviewed head `1866a13c737e` against base/merge-base `1945770a9184`.
   - Null handling is correct: [`WorkflowRequest.java:280`](https://github.com/apache/shardingsphere/blob/1866a13c737edfdd7c56cbe7c10bf92cc564fdf1/mcp/support/src/main/java/org/apache/shardingsphere/mcp/support/workflow/model/WorkflowRequest.java#L279-L280) handles `null` before calling `trim()`; all 5 `WorkflowRequestTest` cases pass.
   - All trailing spaces were removed from the new Javadocs; Spotless and Checkstyle pass.
   - No consumers, reflection paths, or serialization paths depend on `WorkflowRequest.approvedSteps`.
   - Protocol-level `approved_steps` is still passed directly from [`WorkflowExecutionToolHandler.java:64`](https://github.com/apache/shardingsphere/blob/1866a13c737edfdd7c56cbe7c10bf92cc564fdf1/mcp/core/src/main/java/org/apache/shardingsphere/mcp/core/tool/handler/workflow/WorkflowExecutionToolHandler.java#L64-L78) to the execution service for validation; all 23 related tests pass.
   
   ### Coverage
   
   - The GitHub and local triple-dot file lists match, covering 2 files.
   - Reviewed field removal, copy and merge behavior, null normalization, protocol input boundaries, public contracts, allocation changes, test deletions, and formatting changes.
   - Completed the Root Cause and Behavior, Blast Radius and Contracts, Tests/Runtime/Operations, and zero-new-finding convergence passes.
   - No unresolved evidence gaps remain.
   - This result indicates code-scope readiness only; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org