You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by markap14 <gi...@git.apache.org> on 2018/06/07 17:27:40 UTC
[GitHub] nifi pull request #2770: NIFI-5279: Allow components up to 50 milliseconds t...
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/2770
NIFI-5279: Allow components up to 50 milliseconds to complete validat…
…ion before returning from update request
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5279
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2770
----
commit bc7b48fe7ea6824a9a1008e3041a820d940df2ce
Author: Mark Payne <ma...@...>
Date: 2018-06-07T17:26:49Z
NIFI-5279: Allow components up to 50 milliseconds to complete validation before returning from update request
----
---
[GitHub] nifi issue #2770: NIFI-5279: Allow components up to 50 milliseconds to compl...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2770
Reviewing...
---
[GitHub] nifi issue #2770: NIFI-5279: Allow components up to 50 milliseconds to compl...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2770
For those reviewing, the simplest way to verify the fix is to create a DebugFlow processor. Set the "CustomValidate Pause Time" property to "70 millis" and when you apply the update, you should see the component is validating (it's possible that validation will complete before the 50 ms timeout due to java timing precision - if this happens, just configure processor and click "Apply" again). Change the duration to 25 millis and you should no longer see the validation occurring. Of course, because of timing issues you may see some variance.
---
[GitHub] nifi issue #2770: NIFI-5279: Allow components up to 50 milliseconds to compl...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/2770
Verified by running the process Mark described and also adding some other components where I had seen this behavior in the past. Ran `contrib-check` and all tests pass. +1, merging.
---
[GitHub] nifi pull request #2770: NIFI-5279: Allow components up to 50 milliseconds t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2770
---