You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2021/03/08 08:00:09 UTC

[GitHub] [incubator-brpc] bystorm opened a new issue #1351: bvar内存浪费问题

bystorm opened a new issue #1351:
URL: https://github.com/apache/incubator-brpc/issues/1351


   **Describe the bug (描述bug)**
   agent_group.cc文件中类AgentGroup定义成员变量
       static AgentId                              _s_agent_kinds;
       static std::deque<AgentId>                  *_s_free_ids;
       static __thread std::vector<ThreadBlock *>  *_s_tls_blocks;
       _s_agent_kinds与_s_free_ids定义为进程级全局变量，_s_tls_blocks定义为线程级全局变量（每个线程独立一个）。这样用agent_id寻址时，会导致_s_tls_blocks有很多空洞。_s_agent_kinds与_s_free_ids是否应该也改为__thread，每个线程独立一份。
   **To Reproduce (复现方法)**
   code review
   
   **Expected behavior (期望行为)**
   
   
   **Versions (各种版本)**
   OS:
   Compiler:
   brpc:
   protobuf:
   
   **Additional context/screenshots (更多上下文/截图)**
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] bystorm commented on issue #1351: bvar内存浪费问题

Posted by GitBox <gi...@apache.org>.
bystorm commented on issue #1351:
URL: https://github.com/apache/incubator-brpc/issues/1351#issuecomment-792626960


   看错了。


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org

[GitHub] [incubator-brpc] bystorm closed issue #1351: bvar内存浪费问题

Posted by GitBox <gi...@apache.org>.
bystorm closed issue #1351:
URL: https://github.com/apache/incubator-brpc/issues/1351


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org