You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "CRZbulabula (via GitHub)" <gi...@apache.org> on 2026/06/09 06:52:12 UTC
[PR] Fix AddConfigNode retry idempotency [iotdb]
CRZbulabula opened a new pull request, #17874:
URL: https://github.com/apache/iotdb/pull/17874
## Summary
This PR makes ConfigNode membership changes idempotent during `AddConfigNodeProcedure` retry paths.
When `ADD_CONSENSUS_GROUP` times out, the first request may have already created the local ConfigRegion peer on the joining ConfigNode. A retry then sees the consensus group already exists and previously failed the procedure, which could leave the new ConfigNode process alive but not registered in the cluster.
Changes:
- Treat `ConsensusGroupAlreadyExistException` from `createLocalPeer` as success.
- Treat `PeerAlreadyInConsensusGroupException` from `addRemotePeer` as success.
- Treat `PeerNotInConsensusGroupException` from rollback `removeRemotePeer` as success.
- Allow `deleteConfigNodePeer` to clean up a local peer even before the ConfigNode is present in `registeredConfigNodes`, while still rejecting requests targeting a different ConfigNode id.
## Tests
```
mvn spotless:apply -pl iotdb-core/confignode
mvn test -pl iotdb-core/confignode -Dtest=ConsensusManagerTest,ConfigNodeRPCServiceProcessorTest
```
Both commands passed. The local sandbox logs Develocity cache/write warnings for `~/.m2/.develocity`, but Maven reports `BUILD SUCCESS`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AddConfigNode retry idempotency [iotdb]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17874:
URL: https://github.com/apache/iotdb/pull/17874#issuecomment-4657037074
## [](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17874) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17874&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_iotdb&pullRequest=17874&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_iotdb&pullRequest=17874&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17874&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_iotdb&pullRequest=17874&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=17874)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AddConfigNode retry idempotency [iotdb]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #17874:
URL: https://github.com/apache/iotdb/pull/17874#issuecomment-4657339247
## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/17874?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `90.00000%` with `2 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 40.86%. Comparing base ([`3d98ea5`](https://app.codecov.io/gh/apache/iotdb/commit/3d98ea5fd7876c4f8f96033457824f10842100c8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`8a2485a`](https://app.codecov.io/gh/apache/iotdb/commit/8a2485aee4d9c6c7d2429138fa7760d06d43ec9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/iotdb/pull/17874?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...confignode/manager/consensus/ConsensusManager.java](https://app.codecov.io/gh/apache/iotdb/pull/17874?src=pr&el=tree&filepath=iotdb-core%2Fconfignode%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fiotdb%2Fconfignode%2Fmanager%2Fconsensus%2FConsensusManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW90ZGItY29yZS9jb25maWdub2RlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pb3RkYi9jb25maWdub2RlL21hbmFnZXIvY29uc2Vuc3VzL0NvbnNlbnN1c01hbmFnZXIuamF2YQ==) | 86.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/iotdb/pull/17874?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #17874 +/- ##
============================================
+ Coverage 40.85% 40.86% +0.01%
Complexity 2611 2611
============================================
Files 5201 5201
Lines 354010 354028 +18
Branches 45313 45314 +1
============================================
+ Hits 144626 144679 +53
+ Misses 209384 209349 -35
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/iotdb/pull/17874?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix AddConfigNode retry idempotency [iotdb]
Posted by "CRZbulabula (via GitHub)" <gi...@apache.org>.
CRZbulabula merged PR #17874:
URL: https://github.com/apache/iotdb/pull/17874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org