You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/05/14 22:48:53 UTC
[GitHub] rob05c commented on a change in pull request #2262: Part 1 of Range
Request handling
rob05c commented on a change in pull request #2262: Part 1 of Range Request handling
URL: https://github.com/apache/incubator-trafficcontrol/pull/2262#discussion_r188121319
##########
File path: grove/plugin/plugin.go
##########
@@ -91,6 +92,12 @@ type BeforeRespondData struct {
Context *interface{}
}
+type BeforeCacheLookUpData struct {
Review comment:
Any objection to putting the overrideFunc in here? So it'd be `type BeforeCacheLookUpData struct { OverrideCacheKey func(string) ...` and `d.OverrideCacheKey("foo")` ? IMO it'd be cleaner and simpler, to avoid adding the extra parameter to everything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services