[GitHub] [kafka] mumrah commented on a diff in pull request #12269: KAFKA-13966 Set curClaimEpoch after we enqueue bootstrap write

[GitBox <gi...@apache.org>]

mumrah commented on code in PR #12269:
URL: https://github.com/apache/kafka/pull/12269#discussion_r892741833


##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -967,6 +968,10 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
                         metadataVersion = featureControl.metadataVersion();
                     }
 
+                    curClaimEpoch = newEpoch;

Review Comment:
   This is primarily to fix the race in the test code. If we update the volatile sooner, there is a possibility the test code will see the controller as active, enqueue the brokerRegister event, and process the event before the bootstrap metadata gets enqueued.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org