You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by David Radley <da...@uk.ibm.com> on 2017/06/29 10:00:15 UTC
Review Request 60532: i
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Repository: atlas
Description
-------
ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
Diff: https://reviews.apache.org/r/60532/diff/1/
Testing
-------
Ran junits and created a composition relationshipDef as expected.
Thanks,
David Radley
Re: Review Request 60532: ATLAS-1904
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/#review179536
-----------------------------------------------------------
Ship it!
Ship It!
- Apoorv Naik
On June 29, 2017, 10:03 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60532/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:03 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
>
>
> Diff: https://reviews.apache.org/r/60532/diff/1/
>
>
> Testing
> -------
>
> Ran junits and created a composition relationshipDef as expected.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60532: ATLAS-1904
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/#review179537
-----------------------------------------------------------
Ship it!
I've committed the patch on master. Thanks David
- Apoorv Naik
On June 29, 2017, 10:03 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60532/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:03 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
>
>
> Diff: https://reviews.apache.org/r/60532/diff/1/
>
>
> Testing
> -------
>
> Ran junits and created a composition relationshipDef as expected.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60532: ATLAS-1904
Posted by David Radley <da...@uk.ibm.com>.
> On June 29, 2017, 5:12 p.m., Sarath Subramanian wrote:
> > Ship It!
>
> David Radley wrote:
> Hi Srath - please could you commit this, David.
typo sorry Sarath
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/#review179276
-----------------------------------------------------------
On June 29, 2017, 10:03 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60532/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:03 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
>
>
> Diff: https://reviews.apache.org/r/60532/diff/1/
>
>
> Testing
> -------
>
> Ran junits and created a composition relationshipDef as expected.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60532: ATLAS-1904
Posted by David Radley <da...@uk.ibm.com>.
> On June 29, 2017, 5:12 p.m., Sarath Subramanian wrote:
> > Ship It!
Hi Srath - please could you commit this, David.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/#review179276
-----------------------------------------------------------
On June 29, 2017, 10:03 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60532/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 10:03 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
>
>
> Diff: https://reviews.apache.org/r/60532/diff/1/
>
>
> Testing
> -------
>
> Ran junits and created a composition relationshipDef as expected.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60532: ATLAS-1904
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/#review179276
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On June 29, 2017, 3:03 a.m., David Radley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60532/
> -----------------------------------------------------------
>
> (Updated June 29, 2017, 3:03 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
> intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
> intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
>
>
> Diff: https://reviews.apache.org/r/60532/diff/1/
>
>
> Testing
> -------
>
> Ran junits and created a composition relationshipDef as expected.
>
>
> Thanks,
>
> David Radley
>
>
Re: Review Request 60532: ATLAS-1904
Posted by David Radley <da...@uk.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60532/
-----------------------------------------------------------
(Updated June 29, 2017, 10:03 a.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Summary (updated)
-----------------
ATLAS-1904
Repository: atlas
Description
-------
ATLAS-1904. I have cleaned the code up in the validation logic to resolve this issue. I have refactored the junit so the names are more intuitive and it tests this case.
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e39e623a617cd3c90405bb41a348f79624
intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35cc229c9e4b3e54984ae21a9a312cebd96
intg/src/test/java/org/apache/atlas/type/TestAtlasRelationshipType.java 41aac8fb976f15c33765d91f5c2f973b78b232a7
Diff: https://reviews.apache.org/r/60532/diff/1/
Testing
-------
Ran junits and created a composition relationshipDef as expected.
Thanks,
David Radley