You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/08/02 07:46:06 UTC
[GitHub] [ozone] Xushaohong opened a new pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Xushaohong opened a new pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
## What changes were proposed in this pull request?
The original V1 code has been replaced by the V2 code for a long while.
To better understand the code and less misleading information, the code of the raw version should be cleaned up.
I've spent some time checking all the implemented methods in the V1 code and comparing them to the V2 one by one. Luckily the code quality of V2 is good enough that it has covered all places where the V1 code used to work.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5302
## How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2465:
URL: https://github.com/apache/ozone/pull/2465#issuecomment-890825257
> > > thanks @Xushaohong for this work, the changes looks good to me. since we have removed ` DeletedBlockLogImpl` now, maybe we can rename `DeletedBlockLogImplV2` to `DeletedBlockLogImpl`.
> >
> >
> > yep, I think the renaming of `DeletedBlockLogImplV2` needs more vote
>
> Let's go ahead with Rename.
@bshashikant Done with renaming . Pls, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant commented on pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #2465:
URL: https://github.com/apache/ozone/pull/2465#issuecomment-890768064
> > thanks @Xushaohong for this work, the changes looks good to me. since we have removed ` DeletedBlockLogImpl` now, maybe we can rename `DeletedBlockLogImplV2` to `DeletedBlockLogImpl`.
>
> yep, I think the renaming of `DeletedBlockLogImplV2` needs more vote
Let's go ahead with Rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] bshashikant merged pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong closed pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong closed pull request #2465:
URL: https://github.com/apache/ozone/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] Xushaohong commented on pull request #2465: HDDS-5302. CleanUp V1 Code of DeletedBlockLogImpl
Posted by GitBox <gi...@apache.org>.
Xushaohong commented on pull request #2465:
URL: https://github.com/apache/ozone/pull/2465#issuecomment-887955713
> thanks @Xushaohong for this work, the changes looks good to me. since we have removed ` DeletedBlockLogImpl` now, maybe we can rename `DeletedBlockLogImplV2` to `DeletedBlockLogImpl`.
yep, I think the renaming of `DeletedBlockLogImplV2` needs more vote
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org