You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/01 10:17:09 UTC

[GitHub] [fineract] vorburger opened a new pull request #953: minor clean-up to eliminate 'dead code' in CodeValue

vorburger opened a new pull request #953:
URL: https://github.com/apache/fineract/pull/953


   This fixes one of too many ;) warnings Eclipse shows.
   
   It is correct that the condition this checked is useless,
   because that is already checked for in the method it calls.
   (BTW it's actually pretty impressive that JDT, the Eclipse
   Java compiler, can figure this out; it's "smarter" than javac).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #953: minor clean-up to eliminate 'dead code' in CodeValue

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #953:
URL: https://github.com/apache/fineract/pull/953#issuecomment-637475270


   @xurror would you like to review and merge this one?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] xurror merged pull request #953: minor clean-up to eliminate 'dead code' in CodeValue

Posted by GitBox <gi...@apache.org>.
xurror merged pull request #953:
URL: https://github.com/apache/fineract/pull/953


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org