You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/02 11:24:00 UTC
[jira] [Commented] (WEEX-271) Extend the pulldown
WXRefreshComponent to support immediate load of the appear
[ https://issues.apache.org/jira/browse/WEEX-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422151#comment-16422151 ]
ASF GitHub Bot commented on WEEX-271:
-------------------------------------
GitHub user bbmjja8123 opened a pull request:
https://github.com/apache/incubator-weex/pull/1097
fix the bug of [WEEX-271][iOS] Extend the pulldown WXRefreshComponent…
… to support immediate load of the appear
when the contentSize.height < scroll.frame.height, the contentInset isn't correct.
First of all, thank you for your contribution!
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
<!--
How to use github markdown?
### checkable example
- [x] checked
- [ ] not checked
More github Markdown info to see https://guides.github.com/features/mastering-markdown/
-->
CheckList:
**if** *isBugFix* **:**
* [ ] Make sure that you add at least one unit test for the bug which you had fixed.
**elif** *isNewFeature* **:**
* [ ] Update API docs for the component.
* [ ] Update/Add demo to demonstrate new feature.
* [ ] Update test scripts for the feature.
* [ ] Add unit tests for the feature.
<!--
（请在***提交***前删除这段描述）
Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
Our new GitHub repo is https://github.com/apache/incubator-weex
After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
Thank you for your support.
----
注意：Weex 将于 2017-02-24 迁移至 Apache 基金会
届时我们会使用新的 GitHub 仓库：https://github.com/apache/incubator-weex 并在那里继续接受大家的 pull request。
更多详情请关注：https://github.com/weexteam/article/issues/130
感谢理解和支持
-->
<!--
（请在***提交***前删除这段描述）
It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large feature to `master` branch.
See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
----
错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支；
查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
-->
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbmjja8123/incubator-weex im_drop_down
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1097
----
commit 0e2753df06c5c7df7f9cf70283f9345863462c27
Author: jianjun.mjj <ji...@...>
Date: 2018-04-02T11:22:17Z
fix the bug of [WEEX-271][iOS] Extend the pulldown WXRefreshComponent to support immediate load of the appear
when the contentSize.height < scroll.frame.height, the contentInset isn't correct.
----
> Extend the pulldown WXRefreshComponent to support immediate load of the appear
> ------------------------------------------------------------------------------
>
> Key: WEEX-271
> URL: https://issues.apache.org/jira/browse/WEEX-271
> Project: Weex
> Issue Type: Improvement
> Components: iOS
> Affects Versions: 0.18
> Environment: iOS 8.0+
> Reporter: mengjianjun
> Assignee: Adam Feng
> Priority: Major
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> WXRefreshComponent current only support the ②, shuold add new type of①.
> // ①refreshForAppear: load more when refresh component begin appear(if scroll is dragging or decelerating, should delay)
> // ②refreshForWholeVisible: load more until the whole refresh component visible
> NSString *_refreshType;
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)