You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Rohit Deshpande (Jira)" <ji...@apache.org> on 2020/12/20 21:11:00 UTC

[jira] [Created] (KAFKA-10871) StreamTask shouldn't take WallClockTime as input parameter in process method

Rohit Deshpande created KAFKA-10871:
---------------------------------------

             Summary: StreamTask shouldn't take WallClockTime as input parameter in process method
                 Key: KAFKA-10871
                 URL: https://issues.apache.org/jira/browse/KAFKA-10871
             Project: Kafka
          Issue Type: Bug
          Components: streams
    Affects Versions: 2.7.0
            Reporter: Rohit Deshpande
            Assignee: Rohit Deshpande


While working on https://issues.apache.org/jira/browse/KAFKA-10062 I realized process method in StreamTask is taking
wallClockTime as input parameter which is redundant as StreamTask already contains time(https://github.com/apache/kafka/blob/2.5.0/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java#L75) field which represents wallClockTime.
In process method (https://github.com/apache/kafka/blob/2.7/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java#L664), wallClockTime can be passed from StreamTask's time field itself. 
This method was changed as part of pr: https://github.com/apache/kafka/pull/7997. 
As part of https://issues.apache.org/jira/browse/KAFKA-10062, I believe wallClockTime need not be stored in ProcessorContext(https://github.com/apache/kafka/blob/trunk/streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java#L48) but should be fetched from StreamTask's time field. Reference pr: https://github.com/apache/kafka/pull/9744



--
This message was sent by Atlassian Jira
(v8.3.4#803005)