You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/06/22 09:26:58 UTC
[GitHub] [druid] clintropolis opened a new pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension
clintropolis opened a new pull request #11376:
URL: https://github.com/apache/druid/pull/11376
minor refactor to define the "superuser" set of permissions in core druid instead of in the basic authentication extension, as well as a test to make sure there is a wildcard match for all ResourceType and Action combinations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] loquisgon commented on a change in pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension
Posted by GitBox <gi...@apache.org>.
loquisgon commented on a change in pull request #11376:
URL: https://github.com/apache/druid/pull/11376#discussion_r656516073
##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -359,6 +359,51 @@ public static Access authorizeAllResourceActions(
return filteredResources;
}
+ public static List<ResourceAction> makeSuperUserPermissions()
+ {
+ ResourceAction datasourceR = new ResourceAction(
+ new Resource(".*", ResourceType.DATASOURCE),
Review comment:
Given that this pattern, ".*", is used frequently, does it make sense to create a specific string named constant for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11376:
URL: https://github.com/apache/druid/pull/11376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #11376: define superuser permissions set in druid-server instead of druid-basic-auth extension
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #11376:
URL: https://github.com/apache/druid/pull/11376#discussion_r656522356
##########
File path: server/src/main/java/org/apache/druid/server/security/AuthorizationUtils.java
##########
@@ -359,6 +359,51 @@ public static Access authorizeAllResourceActions(
return filteredResources;
}
+ public static List<ResourceAction> makeSuperUserPermissions()
+ {
+ ResourceAction datasourceR = new ResourceAction(
+ new Resource(".*", ResourceType.DATASOURCE),
Review comment:
I thought about that, but anything I could think to name it would be more characters than the pattern, and the pattern seems unlikely to change for this use case, so ended up leaving it like it was. I don't feel very strongly about it though so can change it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org