[DISCUSS]Bug in VariableParser.scala that causes abnormal variable parsing at runtime

[Andy <an...@163.com>]

————— 2022-5-17 —————

Heisenberg 20:29
There is a bug here. There is a bug in VariableParser.scala that causes abnormal variable parsing at runtime. Which branch is this PR on? 1.2.0?

Heisenberg 20:29
@peacewong@WDS Ping brother,

peacewong@WDS 20:36
Brother Longping, what exactly is wrong?

peacewong@WDS 20:36
If it is a bug, it is recommended to put it on the 1.1.2 branch

Heisenberg 20:36
--conf@set configuration runtime wds.linkis.engine.runtime.datasource=d_bigdata_dss1
select * from ${table_name};

Heisenberg 20:36
Such scripts cannot be parsed at runtime

Heisenberg 20:37
It's easy to change

peacewong@WDS 20:38
Understood, using the wrong judgment condition, this suggestion is put in the 1.1.2 branch

Heisenberg 20:38
Both are judged that vars.size() > 0 is problematic

peacewong@WDS 20:38
[expression]

peacewong@WDS 20:38
This should be caused by the fact that the conf variable has not been used before

Heisenberg 20:38
Local DEBUG for a long time, the analysis of this place is too deep [cover face]

Heisenberg 20:38
My DataSource just used

peacewong@WDS 20:38
Hahaha Yes, Brother Longping has tried this function.

peacewong@WDS 20:39
This is directly fixed in 1.1.2

peacewong@WDS 20:39
[expression]

Heisenberg 20:39
OK I submit

peacewong@WDS 20:39
Hmm, 1.1.2 will be merged into 1.2.0 by then




—————  2022-5-17  —————

海森堡 20:29
这里有个BUG，VariableParser.scala中有一个BUG 导致运行时变量解析异常，这个PR放在哪个分支呀？1.2.0？

海森堡 20:29
@peacewong@WDS 平哥，

peacewong@WDS 20:36
龙平兄 具体是什么错呢？

peacewong@WDS 20:36
如果是bug建议放到1.1.2分支的

海森堡 20:36
--conf@set configuration runtime wds.linkis.engine.runtime.datasource=d_bigdata_dss1
select * from ${table_name};

海森堡 20:36
这样的脚本 运行时参数解析不出来

海森堡 20:37
改起来很简单

peacewong@WDS 20:38
理解了，用错判断条件，这个建议放到1.1.2分支的

海森堡 20:38
两处都是判断vars.size() > 0 是有问题的

peacewong@WDS 20:38
[表情]

peacewong@WDS 20:38
这个应该是之前conf变量没有被用过导致

海森堡 20:38
本地DEBUG了半天 ，解析的这个地方套太深了[捂脸]

海森堡 20:38
我的DataSource刚好用到

peacewong@WDS 20:38
哈哈哈 是的，龙平兄尝鲜了这个功能

peacewong@WDS 20:39
这个直接在1.1.2修复下吧

peacewong@WDS 20:39
[表情]

海森堡 20:39
OK 我提交下

peacewong@WDS 20:39
嗯嗯 到时候1.1.2会合并到1.2.0去的

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@linkis.apache.org
For additional commands, e-mail: dev-help@linkis.apache.org