You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2015/02/09 12:09:50 UTC
Review Request 30793: CLOUDSTACK-8235: Fixed test case in
test_bugs.py to
read variable data from configurableData section of test_data.py an d also
fixed wrong parameter name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30793/
-----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-8235
https://issues.apache.org/jira/browse/CLOUDSTACK-8235
Repository: cloudstack-git
Description
-------
Changes:
1. Corrected paramater name podId to podid while adding externally managed cluster in vmware
2. Specified detailed imports
3. Moved the vmware_cluster dict to configurableData section.
4. Pep8 fuixes.
Diffs
-----
test/integration/component/maint/test_bugs.py 160cd1d
tools/marvin/marvin/config/test_data.py d5ed353
Diff: https://reviews.apache.org/r/30793/diff/
Testing
-------
Did not test the actual adding cluster scenario. But the "Invalid parameter" error is gone.
Test case needs to be run against proper data (vmware_cluster information).
Checked the static errors and imports with pyflakes and python command.
Thanks,
Gaurav Aradhye
Re: Review Request 30793: CLOUDSTACK-8235: Fixed test case in
test_bugs.py
to read variable data from configurableData section of test_data.py an d
also fixed wrong parameter name
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30793/#review72343
-----------------------------------------------------------
Ship it!
500baea9b6c816caae93ab2f8d0ba31f99c3f8fc master
- SrikanteswaraRao Talluri
On Feb. 9, 2015, 11:09 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30793/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2015, 11:09 a.m.)
>
>
> Review request for cloudstack and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-8235
> https://issues.apache.org/jira/browse/CLOUDSTACK-8235
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Changes:
> 1. Corrected paramater name podId to podid while adding externally managed cluster in vmware
> 2. Specified detailed imports
> 3. Moved the vmware_cluster dict to configurableData section.
> 4. Pep8 fuixes.
>
>
> Diffs
> -----
>
> test/integration/component/maint/test_bugs.py 160cd1d
> tools/marvin/marvin/config/test_data.py d5ed353
>
> Diff: https://reviews.apache.org/r/30793/diff/
>
>
> Testing
> -------
>
> Did not test the actual adding cluster scenario. But the "Invalid parameter" error is gone.
> Test case needs to be run against proper data (vmware_cluster information).
>
> Checked the static errors and imports with pyflakes and python command.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>