[jira] Commented: (WICKET-1448) SubmitLink bypass jquery submit eventhandler

["xiefei (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-1448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582168#action_12582168 ] 

xiefei commented on WICKET-1448:
--------------------------------

Nowadays, dom event handlers are usually attached to a dom object by  attachEvent/addEventListener methods,   directly setting form.onsubmit, dom.onclick... is not encouraged. 

The javascript generated by SubmitLink now is :

var ff=f;if (ff.onsubmit != undefined) { if (ff.onsubmit()==false) return false; }f.submit();

I think the better way is :

f.fireEvent('onsubmit')

which will invoke all attached eventHandlers, including jQuery's





> SubmitLink bypass jquery submit eventhandler
> --------------------------------------------
>
>                 Key: WICKET-1448
>                 URL: https://issues.apache.org/jira/browse/WICKET-1448
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.2
>            Reporter: xiefei
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.3
>
>
> <form id="wicketForm"><a href="#" wicket:id="submitLink">submit</a></form>
> if:
>         response.renderOnDomReadyJavascript("jQuery('#"+component.getMarkupId()+"').submit(function(){alert('x');return false;})");
> the alert will not show when submitLink is clicked, and the form is submitted
> if: 
>         response.renderOnDomReadyJavascript("document.getElementById('"+component.getMarkupId()+"').onsubmit = function(){alert('x');return false;}");
> the alert will show and the form is not submmitted

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.