[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10074: [doc] Correct all setup documents

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #10074:
URL: https://github.com/apache/dolphinscheduler/pull/10074#discussion_r876632312


##########
docs/docs/en/guide/upgrade.md:
##########
@@ -1,59 +1,71 @@
-# DolphinScheduler Upgrade Documentation
+# DolphinScheduler Upgrade
 
-## Back-Up Previous Version's Files and Database
+## Prepare
 
-## Stop All Services of DolphinScheduler
+### Backup Previous Version's Files and Database
 
- `sh ./script/stop-all.sh`
+To prevent data loss by some miss-operation, it is recommended to back up data before upgrading. The backup way according to your environment.
 
-## Download the Latest Version Installation Package
+### Download the Latest Version Installation Package
 
-- [download](/en-us/download/download.html) the latest version of the installation packages.
-- The following upgrade operations need to be performed in the new version's directory.
+Download the latest binary distribute package from [download](/en-us/download/download.html) and then put it in the different
+directory where current service running. And all below command is running in this directory.
 
-## Database Upgrade
+## Upgrade
 
-- If using MySQL as the database to run DolphinScheduler, please config it in `./bin/env/dolphinscheduler_env.sh`, change username and password to yours, and add MYSQL connector jar into lib dir `./tools/libs`, here we download `mysql-connector-java-8.0.16.jar`, and then correctly configure database connection information. You can download MYSQL connector jar from [here](https://downloads.MySQL.com/archives/c-j/). Otherwise, PostgreSQL is the default database. 
+### Stop All Services of DolphinScheduler
 
-    ```shell
-    export DATABASE=${DATABASE:-mysql}
-    export SPRING_PROFILES_ACTIVE=${DATABASE}
-    export SPRING_DATASOURCE_DRIVER_CLASS_NAME=com.mysql.cj.jdbc.Driver
-    export SPRING_DATASOURCE_URL=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
-    export SPRING_DATASOURCE_USERNAME={user}
-    export SPRING_DATASOURCE_PASSWORD={password}
-    ```
+Stop all services of dolphinscheduler according to your deployment method. If you deploy your dolphinscheduler according to [cluster deployment](./installation/cluster.md), you can stop all services by command `sh ./script/stop-all.sh`.
 
-- Execute database upgrade script:
+### Upgrade Database
 
-    `sh ./tools/bin/upgrade-schema.sh`
+Change configuration in `./bin/env/dolphinscheduler_env.sh` ({user} and {password} are changed to your database username and password), and then run the upgrade script.
 
-## Backend Service Upgrade
+Using MySQL as an example, change the value if you use other databases. Please manually download the [mysql-connector-java driver jar](https://downloads.MySQL.com/archives/c-j/)
+jar package and add it to the `./tools/libs` directory, then change `./bin/ env/dolphinscheduler_env.sh` file
 
-### Modify the Content in `conf/config/install_config.conf` File
+```shell
+export DATABASE=${DATABASE:-mysql}
+export SPRING_PROFILES_ACTIVE=${DATABASE}
+export SPRING_DATASOURCE_DRIVER_CLASS_NAME=com.mysql.cj.jdbc.Driver
+export SPRING_DATASOURCE_URL=jdbc:mysql://127.0.0.1:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8
+export SPRING_DATASOURCE_USERNAME={user}
+export SPRING_DATASOURCE_PASSWORD={password}
+```
+
+Execute database upgrade script: `sh ./tools/bin/upgrade-schema.sh`
+K
+### Upgrade Service
+
+#### Change Configuration `bin/env/install_config.conf`
+
+- If you deploy with Pseudo-Cluster deployment, change it according to [Pseudo-Cluster](./installation/pseudo-cluster.md) section "Modify Configuration".
+- If you deploy with Cluster deployment, change it according to [Cluster](./installation/cluster.md) section "Modify Configuration".
+
+And them run command `sh ./bin/start-all.sh` to start all services. 
 
-- Standalone Deployment please refer to the [Standalone-Deployment](./installation/standalone.md).
-- Cluster Deployment please refer to the [Cluster-Deployment](./installation/cluster.md).
+## Notice
 
-#### Masters Need Attentions
+### Differences of worker group (before or after version 1.3.1 of dolphinscheduler)
 
-Create worker group in 1.3.1 version has a different design: 
+The architecture of worker group is different between version before or after 1.3.1 
 
-- Before version 1.3.1 worker group can be created through UI interface.
+- Before version 1.3.1(include itself) worker group can be created through UI interface.

Review Comment:
   @lenboo I find out in version 300, we can create a worker group in ou UI again, Am I right, and should we change this doc? which version do we support adding worker group in UI again?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org