You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/06 01:50:11 UTC

[PR] test: add first coverage for update ACL rule DTO [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3941:
URL: https://github.com/apache/rocketmq-dashboard/pull/3941

   ### Motivation
   
   `UpdateAclRuleDTO` had no unit coverage for its validation rules or numeric id parsing. This PR adds first coverage.
   
   ### Changes
   
   - id/principal/resource are required.
   - `toAclRuleVO` parses trimmed numeric ids and maps non-numeric ids to null.
   
   ### Verification
   
   - `mvn -B test -Dtest=UpdateAclRuleDTOTest`: 2/2 passed, BUILD SUCCESS


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] test: add first coverage for update ACL rule DTO [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3941: test: add first coverage for update ACL rule DTO
URL: https://github.com/apache/rocketmq-dashboard/pull/3941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org