[jira] [Commented] (HIVE-14031) cleanup metadataReader in OrcEncodedDataReader

["Prasanth Jayachandran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333418#comment-15333418 ] 

Prasanth Jayachandran commented on HIVE-14031:
----------------------------------------------

There are 3 readers stripe reader, data reader and metadata reader. I think close() should call cleanupReaders() which should close all 3 readers. This patch seems to miss closing data reader in cleanupReaders() and stripe reader in close() method. [~sershe] Can you please confirm if it is safe to close all 3 readers in cleanupReaders() and close()? You are more familiar with this part of code.

> cleanup metadataReader in OrcEncodedDataReader
> ----------------------------------------------
>
>                 Key: HIVE-14031
>                 URL: https://issues.apache.org/jira/browse/HIVE-14031
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-14031.1.patch
>
>
> MetadataReader should be closed in OrcEncodedDataReader as a part of cleanupReaders. 
> \cc [~gopalv]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)