[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on a diff in pull request #293: feat(storage-node): add reconcile logic

["Xu-Wentao (via GitHub)" <gi...@apache.org>]

Xu-Wentao commented on code in PR #293:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/293#discussion_r1165036072


##########
shardingsphere-operator/api/v1alpha1/storage_node_types.go:
##########
@@ -17,7 +17,65 @@
 
 package v1alpha1
 
-import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+import (
+	corev1 "k8s.io/api/core/v1"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+type StorageNodePhaseStatus string
+
+const (
+	StorageNodePhaseReady    StorageNodePhaseStatus = "Ready"
+	StorageNodePhaseNotReady StorageNodePhaseStatus = "NotReady"
+)
+
+type StorageNodeConditionType string
+
+// StorageNodeConditionType shows some states during the startup process of storage node
+const (
+	StorageNodeConditionTypeAvailable StorageNodeConditionType = "Available"

Review Comment:
   Just retain the "Available" condition for describe the whole storageNode is available or not, it's depends cluster is ready and all instances are ready.
   We may add more additional conditions for more info in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org