You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2010/12/06 06:26:10 UTC

[jira] Created: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

The all taskid variable's type should be declared as a TaskAttemptID
--------------------------------------------------------------------

                 Key: HAMA-336
                 URL: https://issues.apache.org/jira/browse/HAMA-336
             Project: Hama
          Issue Type: Improvement
          Components: bsp
    Affects Versions: 0.2.0
            Reporter: Edward J. Yoon
            Assignee: Edward J. Yoon
             Fix For: 0.2.0


To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Status: Open  (was: Patch Available)

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch, HAMA-336_v02.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968592#action_12968592 ] 

Hudson commented on HAMA-336:
-----------------------------

+1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12465663/HAMA-336_v02.patch
against trunk revision 1041720.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs +1.  The patch does not introduce any new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/300/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/300/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/300/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/300/console

This message is automatically generated.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch, HAMA-336_v02.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

I've just committed this.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch, HAMA-336_v02.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Attachment: HAMA-336_v02.patch

findbugs warnings removed.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch, HAMA-336_v02.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Status: Patch Available  (was: Open)

Rescheduling.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch, HAMA-336_v02.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Status: Patch Available  (was: Open)

submit patch.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967094#action_12967094 ] 

Hudson commented on HAMA-336:
-----------------------------

-1 overall.  Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12465363/HAMA-336.patch
against trunk revision 1041720.

    @author +1.  The patch does not contain any @author tags.

    tests included +1.  The patch appears to include 3 new or modified tests.

    javadoc +1.  The javadoc tool did not generate any warning messages.

    javac +1.  The applied patch does not generate any new javac compiler warnings.

    release audit +1.  The applied patch does not generate any new release audit warnings.

    findbugs -1.  The patch appears to introduce 4 new Findbugs warnings.

    core tests +1.  The patch passed core unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/299/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/299/findbugsResult/
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/299/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/299/console

This message is automatically generated.

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HAMA-336) The all taskid variable's type should be declared as a TaskAttemptID

Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HAMA-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Edward J. Yoon updated HAMA-336:
--------------------------------

    Attachment: HAMA-336.patch

attach my patch

> The all taskid variable's type should be declared as a TaskAttemptID
> --------------------------------------------------------------------
>
>                 Key: HAMA-336
>                 URL: https://issues.apache.org/jira/browse/HAMA-336
>             Project: Hama
>          Issue Type: Improvement
>          Components: bsp
>    Affects Versions: 0.2.0
>            Reporter: Edward J. Yoon
>            Assignee: Edward J. Yoon
>             Fix For: 0.2.0
>
>         Attachments: HAMA-336.patch
>
>
> To make debugging easy, they were declared as a String by me. They all should be a TaskAttemptID.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.