You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "eschutho (via GitHub)" <gi...@apache.org> on 2025/09/13 01:54:23 UTC
[PR] fix(dashboard): remove visual gap at top of horizontal filter bar [superset]
eschutho opened a new pull request, #35128:
URL: https://github.com/apache/superset/pull/35128
## Summary
- Removes unnecessary visual gap at the top of the horizontal filter bar
- Fixes layout issue where filter bar had excessive top padding
## Problem
The horizontal filter bar was displaying with an unnecessary visual gap at the top due to excessive padding (`theme.sizeUnit * 3px` on the top). This created poor visual alignment between the filter bar and the rest of the dashboard content.
## Solution
- Remove top padding from the `HorizontalBar` styled component
- Change from `padding: ${theme.sizeUnit * 3}px ${theme.sizeUnit * 2}px ...`
- To `padding: 0 ${theme.sizeUnit * 2}px ...`
- Maintains proper side and bottom padding for appropriate spacing
## Visual Impact
- ✅ Eliminates unwanted gap above horizontal filter bar
- ✅ Improves visual alignment with dashboard content
- ✅ Better overall page layout and spacing
- ✅ No impact on filter functionality
## Files Changed
- `superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Horizontal.tsx`
🤖 Generated with [Claude Code](https://claude.ai/code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): remove visual gap at top of horizontal filter bar [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #35128:
URL: https://github.com/apache/superset/pull/35128#issuecomment-3287507512
this is part of the default AntD theme as colorSplit and has a transparency, which makes it look like there is a gap: rgba(5, 5, 5, 0.06)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): remove visual gap at top of horizontal filter bar [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35128:
URL: https://github.com/apache/superset/pull/35128#issuecomment-3287405461
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) is building environment on [GHA](https://github.com/apache/superset/actions/runs/17690774081) for [1927af8](https://github.com/apache/superset/commit/1927af8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): remove visual gap at top of horizontal filter bar [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho closed pull request #35128: fix(dashboard): remove visual gap at top of horizontal filter bar
URL: https://github.com/apache/superset/pull/35128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(dashboard): remove visual gap at top of horizontal filter bar [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35128:
URL: https://github.com/apache/superset/pull/35128#issuecomment-3287410502
🎪 [Showtime](https://github.com/mistercrunch/superset-showtime) deployed environment on [GHA](https://github.com/apache/superset/actions/runs/17690774081) for [1927af8](https://github.com/apache/superset/commit/1927af8)
• **Environment:** http://34.220.221.5:8080 (admin/admin)
• **Lifetime:** 24h auto-cleanup
• **Updates:** New commits create fresh environments automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org