You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2019/01/27 12:07:40 UTC
[kudu-CR] [tools] Describe more table attributes
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12281
Change subject: [tools] Describe more table attributes
......................................................................
[tools] Describe more table attributes
This add more attributes to describe a table, including its column
encoding type, compression type, and default read/write value.
My use case of the extra information is to compare two tables
in the same or different clusters: export the full descriptions
of the two tables into texts, and then use any text compare tool
to check the difference.
Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/int128_util.h
11 files changed, 115 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12281/1
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <40...@qq.com>
[kudu-CR] [tools] Describe more table attributes
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 )
Change subject: [tools] Describe more table attributes
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc@140
PS2, Line 140: ())
> I update this to what web-ui deal with it: https://github.com/apache/kudu/b
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 17:40:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Describe more table attributes
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12281
to look at the new patch set (#3).
Change subject: [tools] Describe more table attributes
......................................................................
[tools] Describe more table attributes
This adds more attributes to `kudu table describe`, including column
encoding type, compression type, and default read/write value.
My use case for the extra information is to compare two tables in the
same or different clusters: export the full descriptions of the two
tables into text, and then use any text compare tool to check the
difference.
Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
---
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/int128_util.h
10 files changed, 118 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12281/3
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] Describe more table attributes
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12281
to look at the new patch set (#2).
Change subject: [tools] Describe more table attributes
......................................................................
[tools] Describe more table attributes
This add more attributes to describe a table, including its column
encoding type, compression type, and default read/write value.
My use case of the extra information is to compare two tables
in the same or different clusters: export the full descriptions
of the two tables into texts, and then use any text compare tool
to check the difference.
Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
---
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/int128_util.h
10 files changed, 121 insertions(+), 40 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/12281/2
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tools] Describe more table attributes
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12281 )
Change subject: [tools] Describe more table attributes
......................................................................
[tools] Describe more table attributes
This adds more attributes to `kudu table describe`, including column
encoding type, compression type, and default read/write value.
My use case for the extra information is to compare two tables in the
same or different clusters: export the full descriptions of the two
tables into text, and then use any text compare tool to check the
difference.
Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Reviewed-on: http://gerrit.cloudera.org:8080/12281
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M src/kudu/cfile/encoding-test.cc
M src/kudu/client/schema.cc
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/types.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
M src/kudu/util/int128_util.h
10 files changed, 118 insertions(+), 28 deletions(-)
Approvals:
Kudu Jenkins: Verified
Will Berkeley: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
[kudu-CR] [tools] Describe more table attributes
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 )
Change subject: [tools] Describe more table attributes
......................................................................
Patch Set 3:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: udi
> Remove.
Done
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: `kudu table des
> `kudu table describe`
Done
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: add
> adds
Done
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@11
PS2, Line 11: fo
> for
Done
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@13
PS2, Line 13: hen u
> text
Done
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h@233
PS2, Line 233: type, compression type, and
> Can you replace this bool parameter with an enum? See https://abseil.io/tip
Done
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc@140
PS2, Line 140: ())
> This is sort of silly, but what if the default is "-"? Also, what if the de
I update this to what web-ui deal with it: https://github.com/apache/kudu/blob/master/src/kudu/server/webui_util.cc#L50, the non-default value will be -, and any string type value will be wraped by "", like "-".
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1761
PS2, Line 1761: ->Precision(30)
> Can you up the precision here to make sure we test int128 values? I think 3
Done
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1796
PS2, Line 1796: kAnotherTableId,
: }, &stdout, &stderr);
> Can you run the tool twice: with and without this flag, to check that the o
Done
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h
File src/kudu/util/int128_util.h:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h@18
PS2, Line 18: #pragma once
:
> Prefer #pragma once.
Done
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <40...@qq.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 04:57:46 +0000
Gerrit-HasComments: Yes
[kudu-CR] [tools] Describe more table attributes
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12281 )
Change subject: [tools] Describe more table attributes
......................................................................
Patch Set 2:
(10 comments)
Looks pretty good. Thanks for adding this.
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: its
Remove.
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: describe a table
`kudu table describe`
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@9
PS2, Line 9: add
adds
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@11
PS2, Line 11: of
for
http://gerrit.cloudera.org:8080/#/c/12281/2//COMMIT_MSG@13
PS2, Line 13: texts
text
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h
File src/kudu/common/schema.h:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.h@233
PS2, Line 233: bool with_attributes = false
Can you replace this bool parameter with an enum? See https://abseil.io/tips/94 for more information and justification.
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc
File src/kudu/common/schema.cc:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/common/schema.cc@140
PS2, Line 140: "-"
This is sort of silly, but what if the default is "-"? Also, what if the default is some giant multiline string, like if the default is itself a stringified Kudu schema. Do you think those cases aren't worth doing more work to cover nicely? Or should we adopt some sort of escaping scheme?
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc
File src/kudu/tools/kudu-admin-test.cc:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1761
PS2, Line 1761: ->Precision(10)
Can you up the precision here to make sure we test int128 values? I think 30 or so is high enough.
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/tools/kudu-admin-test.cc@1796
PS2, Line 1796: kAnotherTableId,
: "-show_attributes=true"
Can you run the tool twice: with and without this flag, to check that the output appears with the flag and doesn't appear without the flag?
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h
File src/kudu/util/int128_util.h:
http://gerrit.cloudera.org:8080/#/c/12281/2/src/kudu/util/int128_util.h@18
PS2, Line 18: #ifndef KUDU_INT128_UTIL_H
: #define KUDU_INT128_UTIL_H
Prefer #pragma once.
--
To view, visit http://gerrit.cloudera.org:8080/12281
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f8cf682f3a2a30f98edbc4aff6951225d8d81e8
Gerrit-Change-Number: 12281
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <40...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Mon, 28 Jan 2019 19:41:45 +0000
Gerrit-HasComments: Yes