You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by cnap <gi...@git.apache.org> on 2016/06/10 02:04:35 UTC

[GitHub] incubator-joshua pull request #23: bug fix: GrammarPacker.java

GitHub user cnap opened a pull request:

    https://github.com/apache/incubator-joshua/pull/23

    bug fix: GrammarPacker.java

    In line 360, the result of splitting an empty string is an array of length 1, so the conditional on line 362 will always be true, resulting in an exception if alignment_line is an empty string. Having the conditional check the length of alignment_line instead solves this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cnap/incubator-joshua patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-joshua/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit d2287bfaa53bff4e0a455827ae957fbc365a813c
Author: Courtney Napoles <cd...@gmail.com>
Date:   2016-06-10T02:04:15Z

    bug fix: GrammarPacker.java
    
    In line 360, the result of splitting an empty string is an array of length 1, so the conditional on line 362 will always be true, resulting in an exception if alignment_line is an empty string. Having the conditional check the length of alignment_line instead solves this.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #23: bug fix: GrammarPacker.java

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-joshua/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---