[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4600: Check DB value for useintable

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #4600: Check DB value for useintable
URL: https://github.com/apache/trafficcontrol/pull/4600#discussion_r404912897
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/types/types_test.go
 ##########
 @@ -168,18 +168,6 @@ func TestCreateInvalidType(t *testing.T) {
 	}
 }
 
-func TestDeleteInvalidType(t *testing.T) {
-	invalidDeleteType := createDummyType("other")
-
-	err, _, statusCode := invalidDeleteType.Delete()
-	if err == nil {
-		t.Fatalf("expected delete type to have an error")
-	}
-	if statusCode != http.StatusNotFound {
 
 Review comment:
   Originally I thought the test no longer was testing anything other than the generic api method, but you are correct; I didn't need to remove it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services