[jira] [Commented] (FLINK-8404) Mark Flip-6 tests with Flip6 annotation

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320205#comment-16320205 ] 

ASF GitHub Bot commented on FLINK-8404:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/5278

    [FLINK-8404] [tests] Mark Flip-6 tests with Flip6 category annotation

    ## What is the purpose of the change
    
    Marks all existing Flip-6 test cases with the Flip6 category annotation. That
    way they are only run if the Flip-6 test profile is active.
    
    This PR is based on #5095.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink markFlip6Tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5278.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5278
    
----
commit 3c4d8452021ea3e84d5f78eeb1b24dcc04adf865
Author: Till Rohrmann <tr...@...>
Date:   2018-01-09T19:37:08Z

    [FLINK-8393] [flip6] Reconnect to last known JobMaster when connection is lost
    
    In case of a heartbeat timeout or a disconnect call, the TaskExecutor tries to
    reconnect to the last known JobMaster location.
    
    This closes #5267.

commit 55ced94f9a25e9572b2206297d44849dc5afb42b
Author: Till Rohrmann <tr...@...>
Date:   2017-10-23T15:02:58Z

    [FLINK-7918] Run AbstractTestBase tests on Flip-6 MiniCluster
    
    This closes #5095.

commit 64a910e5347cf6513e9b8bffbe6354d3819987f9
Author: Till Rohrmann <tr...@...>
Date:   2017-12-01T18:19:29Z

    [hotfix] [tests] Refactor TypeHintITCase to extend AbstractTestBase

commit 608185804f076b68aec6c06aa300e3d63e392339
Author: Till Rohrmann <tr...@...>
Date:   2017-12-01T18:20:04Z

    [hotfix] [tests] Fix JavaProgramTestBase to reset MiniClusterResource#TestEnvironment

commit 32eb9b30be773da939cf23f2a707924eda72b28d
Author: Till Rohrmann <tr...@...>
Date:   2017-12-01T18:20:35Z

    [hotfix] [tests] Fix PageRankITCase, AggregatorsITCase and DataSinkITCase to use fresh result path

commit b329df3371fd35063accb011f6398c87e224c57c
Author: Till Rohrmann <tr...@...>
Date:   2018-01-10T13:13:38Z

    [FLINK-8404] [tests] Mark Flip-6 tests with Flip6 category annotation
    
    Marks all existing Flip-6 test cases with the Flip6 category annotation. That
    way they are only run if the Flip-6 test profile is active.

----


> Mark Flip-6 tests with Flip6 annotation
> ---------------------------------------
>
>                 Key: FLINK-8404
>                 URL: https://issues.apache.org/jira/browse/FLINK-8404
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> After introducing the {{Flip6}} marker interface, we should update all existing Flip-6 tests with this annotation. That way they will only be executed if the Flip-6 profile is active.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)