Re: [PR] CEP-50/CASS-20834: Enable IAuthenticator to declare supported and alterable role options [cassandra]

["jcshepherd (via GitHub)" <gi...@apache.org>]

jcshepherd commented on code in PR #4427:
URL: https://github.com/apache/cassandra/pull/4427#discussion_r2926888840


##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -1294,7 +1294,7 @@ public static GuardrailsOptions getGuardrailsConfig()
         return guardrails;
     }
 
-    private static void applyGuardrails()
+    public static void applyGuardrails()

Review Comment:
   Thanks - daemonInitialization() has effect for only only call per JVM instance (protected by a static flag). Since the test class is exercising multiple configurations (differing on auth config), it's not suitable. I've reverted the change to make applyGuardrails() private again, and am using unsafeDaemonInitialization() (which isn't protected and will reload from configuration) instead. That or I could break up the class into a class-per-test but that seems like overkill. I'd prefer to avoid mocks when I can. Let me know what you think!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org