You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/12 17:45:25 UTC
[GitHub] [apisix-website] KishaniKandasamy opened a new pull request #342: docs: include Helm charts and Docker to documents page
KishaniKandasamy opened a new pull request #342:
URL: https://github.com/apache/apisix-website/pull/342
Fixes: #341
Changes:
add a new field **docs** on the config file including Apisix Helm charts and Docker
Screenshots of the change:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit e62a9eff191705223aa76144e4e25d56102189fc
https://app.netlify.com/sites/apisix/deploys/609f96540cd28f00070b11f8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r632922747
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
Review comment:
It is used in [downloads](https://github.com/apache/apisix-website/blob/master/website/docusaurus.config.js#L23) and declared in [customTheme.css](https://github.com/apache/apisix-website/blob/master/website/src/css/customTheme.css#L5) so I left it as it is.If the color must be a certain value then I will change it:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-840049711
I guess we need different icons for different kinds of doc? @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r632922747
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
Review comment:
It is used in [downloads](https://github.com/apache/apisix-website/blob/master/website/docusaurus.config.js#L23) so I left it as it is.If the color must be a certain value then I will change it:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-840984246
Hi, Is there anything that need to be changed in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit d080cf8bfe01b61a4823458d3d83c9fe4b5b4e8d
https://app.netlify.com/sites/apisix/deploys/609c142cf7a1dd0007092251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #342:
URL: https://github.com/apache/apisix-website/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit 60e925fa08b46678d78924eddc1e444b585cdc77
https://app.netlify.com/sites/apisix/deploys/609f923750670e0007cc5534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit 3e7eb00e8396b370f55496bd74b8bfb011d8086c
https://app.netlify.com/sites/apisix/deploys/609d4a8a0fef3f0007cc5b67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit 7297042916435dd90e295c84e4c1a0fa09cee6e0
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-841786813
> Hi, Is there anything that need to be changed in this PR?
@juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r632991630
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
Review comment:
okay:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan merged pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #342:
URL: https://github.com/apache/apisix-website/pull/342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r632955664
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
Review comment:
No worries I'm just curious why is it not the same with others 🤣
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit 9dd6443edc0b93afbcad1e0142c77220cfa50d0b
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit 38badd26380e7436cbb0f4c76465589983c401d9
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit 7297042916435dd90e295c84e4c1a0fa09cee6e0
https://app.netlify.com/sites/apisix/deploys/609cfe9294cbf50007d567d3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* processing.
Building with commit 584eb541d7da144e2af974d2d0e76e174421ce86
https://app.netlify.com/sites/apisix/deploys/609cff4cf68a20000883ddc3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r632776896
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
+ githubRepo: "apache/apisix",
+ version: "2.5",
+ releaseDate: "2021-04-05",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Dashboard",
+ nameInParamCase: "dashboard",
+ description:
+ "Designed to make it as easy as possible for users to operate Apache APISIX through a frontend interface.",
+ shape: "square",
+ color: "#10B981",
+ githubRepo: "apache/apisix-dashboard",
+ version: "2.6",
+ releaseDate: "2021-04-22",
+ firstDocPath: "/USER_GUIDE",
+ },
+ {
+ name: "APISIX™ Ingress Controller",
+ nameInParamCase: "ingress-controller",
+ description: "An Apache APISIX control plane component.",
+ shape: "hexagon",
+ color: "#2563EB",
+ githubRepo: "apache/apisix-ingress-controller",
+ version: "0.5.0",
+ releaseDate: "2021-04-11",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Helm Charts",
+ nameInParamCase: "helm-charts",
+ description: "An Apache APISIX Helm Charts provide the installation of Apache APISIX components for kubernetes.",
+ shape: "pentagon",
+ color: "#C71585",
+ githubRepo: "apache/apisix-helm-chart",
+ version: "0.4.0",
+ releaseDate: "2021-03-12",
+ firstDocPath: "/apisix",
+ },
+ {
+ name: "APISIX™ Docker",
+ nameInParamCase: "docker",
+ description: "Docker tooling for Apache APISIX.",
+ shape: "diamond",
+ color: "#FFD700",
+ githubRepo: "apache/apisix-helm-chart",
+ version: "1.0.0",
+ releaseDate: "2020-12-1",
+ firstDocPath: "/docker",
Review comment:
```suggestion
firstDocPath: "/build",
```
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
+ githubRepo: "apache/apisix",
+ version: "2.5",
+ releaseDate: "2021-04-05",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Dashboard",
+ nameInParamCase: "dashboard",
+ description:
+ "Designed to make it as easy as possible for users to operate Apache APISIX through a frontend interface.",
+ shape: "square",
+ color: "#10B981",
+ githubRepo: "apache/apisix-dashboard",
+ version: "2.6",
+ releaseDate: "2021-04-22",
+ firstDocPath: "/USER_GUIDE",
+ },
+ {
+ name: "APISIX™ Ingress Controller",
+ nameInParamCase: "ingress-controller",
+ description: "An Apache APISIX control plane component.",
+ shape: "hexagon",
+ color: "#2563EB",
+ githubRepo: "apache/apisix-ingress-controller",
+ version: "0.5.0",
+ releaseDate: "2021-04-11",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Helm Charts",
+ nameInParamCase: "helm-charts",
Review comment:
```suggestion
nameInParamCase: "helm-chart",
```
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
+ githubRepo: "apache/apisix",
+ version: "2.5",
+ releaseDate: "2021-04-05",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Dashboard",
+ nameInParamCase: "dashboard",
+ description:
+ "Designed to make it as easy as possible for users to operate Apache APISIX through a frontend interface.",
+ shape: "square",
+ color: "#10B981",
+ githubRepo: "apache/apisix-dashboard",
+ version: "2.6",
+ releaseDate: "2021-04-22",
+ firstDocPath: "/USER_GUIDE",
+ },
+ {
+ name: "APISIX™ Ingress Controller",
+ nameInParamCase: "ingress-controller",
+ description: "An Apache APISIX control plane component.",
+ shape: "hexagon",
+ color: "#2563EB",
+ githubRepo: "apache/apisix-ingress-controller",
+ version: "0.5.0",
+ releaseDate: "2021-04-11",
+ firstDocPath: "/getting-started",
+ },
+ {
+ name: "APISIX™ Helm Charts",
+ nameInParamCase: "helm-charts",
+ description: "An Apache APISIX Helm Charts provide the installation of Apache APISIX components for kubernetes.",
+ shape: "pentagon",
+ color: "#C71585",
+ githubRepo: "apache/apisix-helm-chart",
+ version: "0.4.0",
+ releaseDate: "2021-03-12",
+ firstDocPath: "/apisix",
+ },
+ {
+ name: "APISIX™ Docker",
+ nameInParamCase: "docker",
+ description: "Docker tooling for Apache APISIX.",
+ shape: "diamond",
+ color: "#FFD700",
+ githubRepo: "apache/apisix-helm-chart",
Review comment:
```suggestion
githubRepo: "apache/apisix-docker",
```
##########
File path: website/docusaurus.config.js
##########
@@ -14,6 +14,65 @@ module.exports = {
events: require("./static/data/events.json"),
repoUrl: "https://github.com/apache/apisix",
docsUrl: "",
+ docs: [
+ {
+ name: "APISIX™",
+ nameInParamCase: "apisix",
+ description: "A dynamic, real-time, high-performance API gateway.",
+ shape: "triangle",
+ color: "var(--ifm-color-primary)",
Review comment:
why color here is not a certain value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-840472280
Hi, Is this okay? color and shape..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit d080cf8bfe01b61a4823458d3d83c9fe4b5b4e8d
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-840218811
It would be better to update `shape` field
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit e62a9eff191705223aa76144e4e25d56102189fc
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] KishaniKandasamy commented on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
KishaniKandasamy commented on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-841786813
> Hi, Is there anything that need to be changed in this PR?
@juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#discussion_r631784004
##########
File path: website/src/assets/icons/diamond.svg
##########
@@ -0,0 +1,3 @@
+<svg xmlns="http://www.w3.org/2000/svg" width="32" height="32" fill="currentColor" class="bi bi-diamond-fill" viewBox="0 0 16 16">
+ <path fill-rule="evenodd" d="M6.95.435c.58-.58 1.52-.58 2.1 0l6.515 6.516c.58.58.58 1.519 0 2.098L9.05 15.565c-.58.58-1.519.58-2.098 0L.435 9.05a1.482 1.482 0 0 1 0-2.098L6.95.435z"/>
+</svg>
Review comment:
Hi, we need to have a blank line at the end of files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #342: docs: include Helm charts and Docker to documents page
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #342:
URL: https://github.com/apache/apisix-website/pull/342#issuecomment-839973228
Deploy preview for *apisix* ready!
Built with commit 2bb9aea7b69af0bbd9f7fd859991a485d6e730db
https://deploy-preview-342--apisix.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org