[GitHub] [incubator-yunikorn-web] sunilgovind commented on a change in pull request #48: YUNIKORN-406: Fix direct yunikorn scheduler api access from yunikorn web

[GitBox <gi...@apache.org>]

sunilgovind commented on a change in pull request #48:
URL: https://github.com/apache/incubator-yunikorn-web/pull/48#discussion_r509955969



##########
File path: Dockerfile.dev
##########
@@ -9,20 +7,32 @@
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
 #
-#     http://www.apache.org/licenses/LICENSE-2.0
+#      http://www.apache.org/licenses/LICENSE-2.0

Review comment:
       unwanted line of change.

##########
File path: Makefile
##########
@@ -94,6 +74,32 @@ clean:
 	rm -rf ./out
 	rm -rf ./out-tsc
 
+# Build an image based on the dev build version
+.PHONY: dev-image
+dev-image:
+	docker build -t ${REGISTRY}/yunikorn-web:dev-${VERSION} -f ./Dockerfile.dev .
+
+# Run the web interface from the dev build image
+.PHONY: dev-run-image

Review comment:
       lets call it as run-image?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org