You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2018/12/12 12:44:44 UTC
svn commit: r1848755 - in
/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation:
AddValidationInformation.java CertInformationCollector.java
Author: tilman
Date: Wed Dec 12 12:44:44 2018
New Revision: 1848755
URL: http://svn.apache.org/viewvc?rev=1848755&view=rev
Log:
PDFBOX-3017: rename method that will be used for OCSP and CRL certificates and use simpler parameter type
Modified:
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationCollector.java
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java?rev=1848755&r1=1848754&r2=1848755&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java Wed Dec 12 12:44:44 2018
@@ -362,7 +362,7 @@ public class AddValidationInformation
// "ocsp responses usually are signed by special certificates.
// Often these certificates are marked to not require revocation checks but not always"
// see also updated comment by mkl in PDFBOX-3017 on 21.11.2018
-// CertSignatureInformation ocspCertInfo = certInformationHelper.getOCSPCertInfo(basicResponse.getCerts()[0]);
+// CertSignatureInformation ocspCertInfo = certInformationHelper.getCertInfo(basicResponse.getCerts()[0]);
// addRevocationDataRecursive(ocspCertInfo);
//TODO
Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationCollector.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationCollector.java?rev=1848755&r1=1848754&r2=1848755&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationCollector.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/CertInformationCollector.java Wed Dec 12 12:44:44 2018
@@ -391,21 +391,21 @@ public class CertInformationCollector
}
/**
- * Traverse the OCSP certificate.
+ * Traverse a certificate.
*
- * @param certHolder
+ * @param certificate
* @return
* @throws CertificateProccessingException
*/
- CertSignatureInformation getOCSPCertInfo(X509CertificateHolder certHolder) throws CertificateProccessingException
+ CertSignatureInformation getCertInfo(X509Certificate certificate) throws CertificateProccessingException
{
try
{
CertSignatureInformation certSignatureInformation = new CertSignatureInformation();
- traverseChain(certConverter.getCertificate(certHolder), certSignatureInformation, MAX_CERTIFICATE_CHAIN_DEPTH);
+ traverseChain(certificate, certSignatureInformation, MAX_CERTIFICATE_CHAIN_DEPTH);
return certSignatureInformation;
}
- catch (IOException | CertificateException ex)
+ catch (IOException ex)
{
throw new CertificateProccessingException(ex);
}