You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jagadeesanas2 <gi...@git.apache.org> on 2016/10/27 09:21:00 UTC
[GitHub] spark pull request #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline ...
GitHub user jagadeesanas2 opened a pull request:
https://github.com/apache/spark/pull/15660
[SPARK-18133][Examples] [ML] [Python ML Pipeline Example has syntax e\u2026
## What changes were proposed in this pull request?
In Python 3, there is only one integer type (i.e., int), which mostly behaves like the long type in Python 2. Since Python 3 won't accept "L", so removed "L" in all examples.
## How was this patch tested?
Unit tests.
\u2026rrors]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ibmsoe/spark SPARK-18133
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/15660.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #15660
----
commit 76d24a6559df150de28e991e316edf10e5e66022
Author: Jagadeesan <as...@us.ibm.com>
Date: 2016-10-27T09:12:52Z
[SPARK-18133][Examples] [ML] [Python ML Pipeline Example has syntax errors]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15660
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by vincentpham1991 <gi...@git.apache.org>.
Github user vincentpham1991 commented on the issue:
https://github.com/apache/spark/pull/15660
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15660
LGTM2, merged into master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/15660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by yanboliang <gi...@git.apache.org>.
Github user yanboliang commented on the issue:
https://github.com/apache/spark/pull/15660
@jagadeesanas2 I'd like to merge it into branch-2.0 also, but there is conflict. Could you please prepare a separate PR for branch-2.0? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15660
**[Test build #67637 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67637/consoleFull)** for PR 15660 at commit [`76d24a6`](https://github.com/apache/spark/commit/76d24a6559df150de28e991e316edf10e5e66022).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/15660
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67637/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by jagadeesanas2 <gi...@git.apache.org>.
Github user jagadeesanas2 commented on the issue:
https://github.com/apache/spark/pull/15660
@yanboliang PR for branch-2.0 https://github.com/apache/spark/pull/15728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #15660: [SPARK-18133][Examples] [ML] [Python ML Pipeline Example...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/15660
**[Test build #67637 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/67637/consoleFull)** for PR 15660 at commit [`76d24a6`](https://github.com/apache/spark/commit/76d24a6559df150de28e991e316edf10e5e66022).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org