You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/16 15:34:12 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request #13366: [owasp] Periodic jobs on active branches
nicoloboschi opened a new pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366
### Motivation
OWASP dependency check is never run against active release branches, so we are not aware to have a fixable vulnerability on an active branches.
### Modifications
* Added periodic GH workflow job to run OWASP dependency check against branch-2.7, branch-2.8, branch-2.9
* Extracted the runner command from the `master` branch workflow to a custom action
### Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#issuecomment-995977340
can you discuss this on dev@ please ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#discussion_r773985539
##########
File path: .github/workflows/ci-owasp-dependency-check.yaml
##########
@@ -30,10 +30,22 @@ jobs:
name: Run OWASP Dependency Check
Review comment:
One small modification, it's worth adding `${{ matrix.name }}` are part of the name so that the jobs can be identified in the GitHub Actions UI and reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#discussion_r771063581
##########
File path: .github/workflows/ci-owasp-dependency-check-2.7.yaml
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - OWASP Dependency Check - Branch 2.7
+on:
+ schedule:
Review comment:
Why not trigger this only when there has a PR to the branch or push code to the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#discussion_r773985929
##########
File path: .github/workflows/ci-owasp-dependency-check.yaml
##########
@@ -30,10 +30,22 @@ jobs:
name: Run OWASP Dependency Check
Review comment:
example: https://github.com/apache/pulsar/blob/4d3a52048bcd1cbb73c6f219be015ccba3110fe0/.github/workflows/ci-maven-cache-update.yaml#L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#discussion_r772158621
##########
File path: .github/workflows/ci-owasp-dependency-check-2.7.yaml
##########
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: CI - OWASP Dependency Check - Branch 2.7
+on:
+ schedule:
Review comment:
@zymap The CI capacity isn't infinite. That's one reason to run this only as a scheduled job. Security issues will be discovered independently from the commits. That's another reason to run scheduled jobs at least once per day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#issuecomment-999632913
thanks @lhotari , now it's so much better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13366: [owasp] Periodic jobs on active branches
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13366:
URL: https://github.com/apache/pulsar/pull/13366#discussion_r773985539
##########
File path: .github/workflows/ci-owasp-dependency-check.yaml
##########
@@ -30,10 +30,22 @@ jobs:
name: Run OWASP Dependency Check
Review comment:
One small modification, it's worth adding `${{ matrix.name }}` as part of the name so that the jobs can be identified in the GitHub Actions UI and reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org