You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/27 18:53:18 UTC
[GitHub] [superset] rusackas opened a new pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
rusackas opened a new pull request #18204:
URL: https://github.com/apache/superset/pull/18204
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Attempting to resolve #18129 by bumping the Echarts package to 0.18.22.
Note that `master` has moved on to monorepo since that release was cut, so this is a little wierd
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: Fixes #18129
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #18204:
URL: https://github.com/apache/superset/pull/18204#discussion_r794186543
##########
File path: superset-frontend/package.json
##########
@@ -92,7 +92,7 @@
"@superset-ui/legacy-preset-chart-big-number": "^0.18.19",
"@superset-ui/legacy-preset-chart-deckgl": "^0.4.13",
"@superset-ui/legacy-preset-chart-nvd3": "^0.18.19",
- "@superset-ui/plugin-chart-echarts": "^0.18.19",
+ "@superset-ui/plugin-chart-echarts": "^0.18.22",
Review comment:
`superset-ui/plugin-chart-echarts` depends on `superset-ui/core 0.18.22` https://github.com/apache-superset/superset-ui/blob/v0.18.22/plugins/plugin-chart-echarts/package.json
Can we release a post-monorepo release to resolve this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #18204:
URL: https://github.com/apache/superset/pull/18204#discussion_r793917718
##########
File path: superset-frontend/package.json
##########
@@ -92,7 +92,7 @@
"@superset-ui/legacy-preset-chart-big-number": "^0.18.19",
"@superset-ui/legacy-preset-chart-deckgl": "^0.4.13",
"@superset-ui/legacy-preset-chart-nvd3": "^0.18.19",
- "@superset-ui/plugin-chart-echarts": "^0.18.19",
+ "@superset-ui/plugin-chart-echarts": "^0.18.22",
Review comment:
I'm not sure we can do a surgical bump of `@superset-ui/plugin-chart-echarts` from 0.18.19 to 0.18.22, as it will cause two different versions of `@superset-ui/core` to be installed. The only viable option I can think of is to pull in the following `superset-ui` bumps that will end up bringing in that missing cherry:
- #17362
- #17379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #18204:
URL: https://github.com/apache/superset/pull/18204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a change in pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on a change in pull request #18204:
URL: https://github.com/apache/superset/pull/18204#discussion_r794186543
##########
File path: superset-frontend/package.json
##########
@@ -92,7 +92,7 @@
"@superset-ui/legacy-preset-chart-big-number": "^0.18.19",
"@superset-ui/legacy-preset-chart-deckgl": "^0.4.13",
"@superset-ui/legacy-preset-chart-nvd3": "^0.18.19",
- "@superset-ui/plugin-chart-echarts": "^0.18.19",
+ "@superset-ui/plugin-chart-echarts": "^0.18.22",
Review comment:
`superset-ui/plugin-chart-echarts` depends on `superset-ui/core 0.18.22` https://github.com/apache-superset/superset-ui/blob/v0.18.22/plugins/plugin-chart-echarts/package.json
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #18204: fix(echarts): Area Chart regression — bumping to 0.18.22 for v1.4.x
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #18204:
URL: https://github.com/apache/superset/pull/18204#discussion_r793917718
##########
File path: superset-frontend/package.json
##########
@@ -92,7 +92,7 @@
"@superset-ui/legacy-preset-chart-big-number": "^0.18.19",
"@superset-ui/legacy-preset-chart-deckgl": "^0.4.13",
"@superset-ui/legacy-preset-chart-nvd3": "^0.18.19",
- "@superset-ui/plugin-chart-echarts": "^0.18.19",
+ "@superset-ui/plugin-chart-echarts": "^0.18.22",
Review comment:
I'm not sure we can do a surgical bump of `@superset-ui/plugin-chart-echarts` from 0.18.19 to 0.18.22 without also bumping all other `@superset-ui` packages, as it will cause two different versions of `@superset-ui/core` to be installed. The only viable option I can think of is to pull in the following `superset-ui` bumps that will end up bringing in that missing cherry:
- #17362
- #17379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org