You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "v-pat (via GitHub)" <gi...@apache.org> on 2026/09/05 19:40:42 UTC
[PR] Add Has Events filter to the Assets list view [airflow]
v-pat opened a new pull request, #72575:
URL: https://github.com/apache/airflow/pull/72575
closes: #72281
Add a **Has Events** filter to the Assets list page.
## What changes
**API**: adds a boolean `has_events` query parameter to the UI assets endpoint that filters assets having at least one `AssetEvent`:
- `has_events=true` → assets with at least one event
- `has_events=false` → assets with no events
- parameter absent → all assets (unchanged behaviour)
The implementation mirrors the existing `_HasAssetScheduleFilter` precedent in `api_fastapi/common/parameters.py`, filtering `AssetModel.id` against a distinct subquery of `AssetEvent.asset_id`. A subquery is used rather than a null-check on the outer-joined `last_asset_event_timestamp` so it does not depend on the join aliasing.
**UI**: adds a SELECT (Yes/No) filter control on the Assets list, held in the URL so a filtered view is shareable and survives reloads. A select (rather than a checkbox) is used so an unset filter is distinct from `false`, matching the existing `FAVORITE`/`MISSED` filter pattern.
- `searchParams.ts`, `useFiltersHandler.ts`, `filterConfigs.tsx`, `AssetsList.tsx`, and the `assets:filters` translation namespace.
**Generated**: OpenAPI spec (`_private_ui.yaml`) and UI client (`openapi-gen/`) regenerated via the codegen tooling — not hand-edited.
## Tests
Added to `airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py` covering all three states (`true`, `false`, parameter absent), with an asset that has events and one that has none.
## Verification
- `breeze testing core-tests airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_assets.py` → 35 passed
- `pnpm tsc` and UI lint → clean
- prek hooks pass for the changed files (ruff, mypy, black, i18n checks)
cc @jroachgolf84
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Has Events filter to the Assets list view [airflow]
Posted by "jroachgolf84 (via GitHub)" <gi...@apache.org>.
jroachgolf84 commented on PR #72575:
URL: https://github.com/apache/airflow/pull/72575#issuecomment-5585271822
+1 to what @ColtenOuO said. There is already a PR open for this. Please review there!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Has Events filter to the Assets list view [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #72575:
URL: https://github.com/apache/airflow/pull/72575#issuecomment-5554311364
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Has Events filter to the Assets list view [airflow]
Posted by "v-pat (via GitHub)" <gi...@apache.org>.
v-pat commented on PR #72575:
URL: https://github.com/apache/airflow/pull/72575#issuecomment-5590538404
@ColtenOuO @jroachgolf84 got it. closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Has Events filter to the Assets list view [airflow]
Posted by "v-pat (via GitHub)" <gi...@apache.org>.
v-pat closed pull request #72575: Add Has Events filter to the Assets list view
URL: https://github.com/apache/airflow/pull/72575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org