You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/04/10 21:30:53 UTC
Review Request 58322: Small fixes in Log Search
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-20727
https://issues.apache.org/jira/browse/AMBARI-20727
Repository: ambari
Description
-------
Remove some unused codes, suppress some warnings with annotations, fix generics.
Diffs
-----
ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java bcfc4db
ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 7ef967c
ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java d5e807b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java 124ce40
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 27a6705
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java cf9d200
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java f4e70d7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java 35175b6
ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a
Diff: https://reviews.apache.org/r/58322/diff/1/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 58322: Small fixes in Log Search
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/#review171737
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On April 10, 2017, 9:30 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58322/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 9:30 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20727
> https://issues.apache.org/jira/browse/AMBARI-20727
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove some unused codes, suppress some warnings with annotations, fix generics.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java bcfc4db
> ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 7ef967c
> ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java d5e807b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java 124ce40
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 27a6705
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java cf9d200
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java f4e70d7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java 35175b6
> ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a
>
>
> Diff: https://reviews.apache.org/r/58322/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58322: Small fixes in Log Search
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/#review171612
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On April 10, 2017, 9:30 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58322/
> -----------------------------------------------------------
>
> (Updated April 10, 2017, 9:30 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-20727
> https://issues.apache.org/jira/browse/AMBARI-20727
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Remove some unused codes, suppress some warnings with annotations, fix generics.
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576
> ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java bcfc4db
> ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 25e4306
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 7ef967c
> ambari-logsearch/ambari-logsearch-server/pom.xml 52bda8d
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java d5e807b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java 124ce40
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 27a6705
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 49465d5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java cf9d200
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java f4e70d7
> ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java 35175b6
> ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a
>
>
> Diff: https://reviews.apache.org/r/58322/diff/1/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 58322: Small fixes in Log Search
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/
-----------------------------------------------------------
(Updated May 30, 2017, 4:18 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
actualize
Bugs: AMBARI-20727
https://issues.apache.org/jira/browse/AMBARI-20727
Repository: ambari
Description
-------
Remove some unused codes, suppress some warnings with annotations, fix generics.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java bcfc4db
ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 5d6f8b6
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 8a3d26d
ambari-logsearch/ambari-logsearch-server/pom.xml b505c12
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java d5e807b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java 124ce40
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 99d2675
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java cddfc85
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java cb9e806
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java cf9d200
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java f4e70d7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java 35175b6
ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 44fbd4d
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2 a818fe0
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2 63f9f0a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java c949ca2
Diff: https://reviews.apache.org/r/58322/diff/3/
Changes: https://reviews.apache.org/r/58322/diff/2-3/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 58322: Small fixes in Log Search
Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58322/
-----------------------------------------------------------
(Updated April 13, 2017, 4:23 p.m.)
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Changes
-------
add propert url for log4j.dtd in the log4j properties too + upgrade
Bugs: AMBARI-20727
https://issues.apache.org/jira/browse/AMBARI-20727
Repository: ambari
Description
-------
Remove some unused codes, suppress some warnings with annotations, fix generics.
Diffs (updated)
-----
ambari-logsearch/ambari-logsearch-appender/pom.xml e14d576
ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchApiSteps.java bcfc4db
ambari-logsearch/ambari-logsearch-logfeeder/pom.xml 5d6f8b6
ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/log4j.xml 8a3d26d
ambari-logsearch/ambari-logsearch-server/pom.xml b505c12
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/converter/AbstractLogRequestFacetQueryConverter.java d5e807b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java 124ce40
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java 27a6705
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java 25e3271
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java 6b40cb5
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java 9ce209b
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/authenticate/LogsearchAuthSuccessHandler.java cf9d200
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKrbFilter.java f4e70d7
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/model/JWTAuthenticationToken.java 35175b6
ambari-logsearch/ambari-logsearch-server/src/main/resources/log4j.xml 547841a
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java 8a4afe9
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-log4j.xml.j2 a818fe0
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2 63f9f0a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java fec041c
Diff: https://reviews.apache.org/r/58322/diff/2/
Changes: https://reviews.apache.org/r/58322/diff/1-2/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely