You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/24 21:29:15 UTC

[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #39098: [SPARK-41553][PS][PYTHON][CORE] Change `num_files` to `repartition`

dongjoon-hyun commented on code in PR #39098:
URL: https://github.com/apache/spark/pull/39098#discussion_r1056874804


##########
python/pyspark/pandas/generic.py:
##########
@@ -671,8 +671,8 @@ def to_csv(
 
         .. note:: pandas-on-Spark writes CSV files into the directory, `path`, and writes
             multiple `part-...` files in the directory when `path` is specified.
-            This behavior was inherited from Apache Spark. The number of files can
-            be controlled by `num_files`.
+            This behavior was inherited from Apache Spark. The number of partitions can
+            be controlled by `num_files`. This is deprecated use `repartition`.

Review Comment:
   ```python
   - This is deprecated use `repartition`.
   + This is deprecated in favor of `repartition`.
   ```
   
   Or,
   
   ```python
   - This is deprecated use `repartition`.
   + This is deprecated. Use `repartition` instead.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org