[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #19081: Add test case for OptimizerContext.addSchema()#18682

[GitBox <gi...@apache.org>]

terrymanu commented on code in PR #19081:
URL: https://github.com/apache/shardingsphere/pull/19081#discussion_r919620506


##########
shardingsphere-infra/shardingsphere-infra-federation/shardingsphere-infra-federation-optimizer/src/test/java/org/apache/shardingsphere/infra/federation/optimizer/context/OptimizerContextTest.java:
##########
@@ -86,7 +86,15 @@ public void assertAlterDatabase() {
         assertTrue(schemaMetadata.isPresent());
         assertTrue(schemaMetadata.get().getTables().containsKey("bar_tbl"));
     }
-    
+
+    @Test
+    public void assertAddSchema() {
+        OptimizerContext optimizerContext = createOptimizerContext();
+        assertFalse(optimizerContext.getFederationMetaData().getDatabases().get("foo_db").getSchemaMetadata("foo_schema_ts").isPresent());

Review Comment:
   Is it necessary to assert expect value?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org