You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/14 00:24:58 UTC

[GitHub] joshwalters commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice

joshwalters commented on a change in pull request #3461: Fixed dashboard filters carrying over to explore slice
URL: https://github.com/apache/incubator-superset/pull/3461#discussion_r138772263
 
 

 ##########
 File path: superset/assets/javascripts/dashboard/components/SliceCell.jsx
 ##########
 @@ -42,10 +42,20 @@ function SliceCell({ expandedSlices, removeSlice, slice }) {
               >
                 <i className="fa fa-pencil" />
               </a>
-              <a href={getExploreUrl(slice.form_data, 'csv')} title="Export CSV" data-toggle="tooltip">
+              <a
+                className="exportCSV"
+                href={getExploreUrl(slice.form_data, 'csv')}
+                title="Export CSV"
+                data-toggle="tooltip"
+              >
 
 Review comment:
   Are these lines the same as in master, but formatted differently?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services