[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #11238: feat: Option to run npm dev-server (hot reload) while calling docker-compose up

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #11238:
URL: https://github.com/apache/incubator-superset/pull/11238#discussion_r503397933



##########
File path: docker-compose.yml
##########
@@ -73,8 +74,10 @@ services:
   superset-node:
     image: node:12
     container_name: superset_node
-    command: ["bash", "-c", "cd /app/superset-frontend && npm install -f --no-optional --global webpack webpack-cli && npm install -f --no-optional && npm run dev"]
+    command: ["/app/docker-frontend.sh"]
     env_file: docker/.env
+    environment:

Review comment:
       If running the dev server, you probably need to expose port 3000, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org