You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2017/08/11 03:33:17 UTC
[kudu-CR] [java] Remove double brackets from wrapper script
Grant Henke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7655
Change subject: [java] Remove double brackets from wrapper script
......................................................................
[java] Remove double brackets from wrapper script
When running on Jenkins the gradle wrapper script causes:
`[[: not found`
This is because the wrapper script is a shell script
and not a bash script. In that case [[ is not built in.
Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/7655/1
--
To view, visit http://gerrit.cloudera.org:8080/7655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
[kudu-CR] [java] Remove double brackets from wrapper script
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Remove double brackets from wrapper script
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7655/2//COMMIT_MSG
Commit Message:
PS2, Line 12: This is because the wrapper script is a shell script
: and not a bash script
FWIW, we do enforce that /bin/bash is the interpreter for all Kudu shell scripts. We can do that for gradlew too, if that's interesting (though if it's just copied into our repo verbatim from an external source, I can also understand keeping it this way).
--
To view, visit http://gerrit.cloudera.org:8080/7655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Remove double brackets from wrapper script
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: [java] Remove double brackets from wrapper script
......................................................................
[java] Remove double brackets from wrapper script
When running on Jenkins the gradle wrapper script causes:
`[[: not found`
This is because the wrapper script is a shell script
and not a bash script. In that case [[ is not built in.
Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Reviewed-on: http://gerrit.cloudera.org:8080/7655
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/gradle/wrapper.gradle
M java/gradlew
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/7655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [java] Remove double brackets from wrapper script
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change.
Change subject: [java] Remove double brackets from wrapper script
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7655/2//COMMIT_MSG
Commit Message:
Line 13: and not a bash script. In that case [[ is not built in.
> FWIW, we do enforce that /bin/bash is the interpreter for all Kudu shell sc
This file is auto-generated by `gradle wrapper` and then we inject a few lines to support not checking a jar in. It's probably less risky not to change it.
--
To view, visit http://gerrit.cloudera.org:8080/7655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [java] Remove double brackets from wrapper script
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: [java] Remove double brackets from wrapper script
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7655
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I839c47bbef8bf901047b9379be958f4cebbd406e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke <gr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No