You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Mikhail Antonov (JIRA)" <ji...@apache.org> on 2014/06/07 02:45:02 UTC

[jira] [Commented] (HBASE-11307) Deprecate SlabCache

    [ https://issues.apache.org/jira/browse/HBASE-11307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020590#comment-14020590 ] 

Mikhail Antonov commented on HBASE-11307:
-----------------------------------------

A few comments - 

import org.apache.hadoop.hbase.io.hfile.bucket.BucketCache; - seems unused import in DoubleBlockCache?

Do you think we need to add deprecated javadoc notes to SingleSizeCache, Slab and SlabItemActionWatcher classes, and they're annotated so?

Looks good to me.

> Deprecate SlabCache
> -------------------
>
>                 Key: HBASE-11307
>                 URL: https://issues.apache.org/jira/browse/HBASE-11307
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>             Fix For: 0.99.0
>
>         Attachments: HBASE-11307.00.patch
>
>
> BucketCache is more feature-full than SlabCache. My performance testing indicates that SlabCache doesn't perform well as memory footprint grows. I believe BucketCache is seeing more production usage than SlabCache at this point. I suggest we consolidate on BucketCache.



--
This message was sent by Atlassian JIRA
(v6.2#6252)