[GitHub] [solr] risdenk commented on a diff in pull request #1128: SOLR-16427: Evaluate and fix errorprone rules - part 4

[GitBox <gi...@apache.org>]

risdenk commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1005843737


##########
solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java:
##########
@@ -72,16 +72,16 @@ public class DistribPackageStore implements PackageStore {
   private final CoreContainer coreContainer;
   private Map<String, FileInfo> tmpFiles = new ConcurrentHashMap<>();
 
-  private final Path solrhome;
+  private final Path solrHome;
 
   public DistribPackageStore(CoreContainer coreContainer) {
     this.coreContainer = coreContainer;
-    this.solrhome = Paths.get(this.coreContainer.getSolrHome());
+    this.solrHome = Paths.get(this.coreContainer.getSolrHome());

Review Comment:
   @sonatype-lift ignore



##########
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##########
@@ -1628,9 +1629,9 @@ public DirectoryFileStream(SolrParams solrParams) {
     }
 
     // Throw exception on directory traversal attempts
-    protected String validateFilenameOrError(String filename) {
-      if (filename != null) {
-        Path filePath = Paths.get(filename);
+    protected String validateFilenameOrError(String fileName) {
+      if (fileName != null) {
+        Path filePath = Paths.get(fileName);

Review Comment:
   @sonatype-lift ignore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org