You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/12/29 15:52:34 UTC
svn commit: r1648353 - in
/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff:
JpegImageData.java TiffElement.java TiffImageData.java
Author: sebb
Date: Mon Dec 29 14:52:34 2014
New Revision: 1648353
URL: http://svn.apache.org/r1648353
Log:
IMAGING-117 Reduce visibility of mutable array; use existing getter
Modified:
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/JpegImageData.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffElement.java
commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/JpegImageData.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/JpegImageData.java?rev=1648353&r1=1648352&r2=1648353&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/JpegImageData.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/JpegImageData.java Mon Dec 29 14:52:34 2014
@@ -24,7 +24,7 @@ public class JpegImageData extends TiffE
@Override
public String getElementDescription(final boolean verbose) {
- return "Jpeg image data: " + data.length + " bytes";
+ return "Jpeg image data: " + getDataLength() + " bytes";
}
}
Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffElement.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffElement.java?rev=1648353&r1=1648352&r2=1648353&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffElement.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffElement.java Mon Dec 29 14:52:34 2014
@@ -45,7 +45,7 @@ public abstract class TiffElement {
public abstract String getElementDescription(boolean verbose);
public static abstract class DataElement extends TiffElement {
- public final byte[] data;
+ private final byte[] data;
public DataElement(final long offset, final int length, final byte[] data) {
super(offset, length);
@@ -57,6 +57,9 @@ public abstract class TiffElement {
return data;
}
+ public int getDataLength() {
+ return data.length;
+ }
}
public static final class Stub extends TiffElement {
Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java?rev=1648353&r1=1648352&r2=1648353&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java (original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/tiff/TiffImageData.java Mon Dec 29 14:52:34 2014
@@ -146,7 +146,7 @@ public abstract class TiffImageData {
@Override
public String getElementDescription(final boolean verbose) {
- return "Tiff image data: " + data.length + " bytes";
+ return "Tiff image data: " + getDataLength() + " bytes";
}
}
@@ -161,7 +161,7 @@ public abstract class TiffImageData {
@Override
public String getElementDescription(final boolean verbose) {
- return "Tiff image data: " + data.length + " bytes";
+ return "Tiff image data: " + getDataLength() + " bytes";
}
@Override