[GitHub] [solr] magibney commented on pull request #1236: SOLR-16585: Fix NPE in MatchAllDocs pagination

["magibney (via GitHub)" <gi...@apache.org>]

magibney commented on PR #1236:
URL: https://github.com/apache/solr/pull/1236#issuecomment-1441691759

   [testMatchAllDocsPlain()](https://github.com/apache/solr/pull/1236/files#diff-87d99efc408087bfac0b86439e9d396699535d80c21f4e5792ff79e90184ec16R244-R256) was updated to hit a wide variety of offsets, in and out of range of the target docset. That's all for now, but that was the big gap that prevented catching this. 
   
   At a high level, what other combinations were you thinking should be tested? I don't actually think smoke tests add that much with this. Couldn't hurt; but the problem here was "no tests", not "no integration tests". As alarming as this regression was, I don't see anything inherent in this functionality to indicate a need for integration tests for this, any more than any other functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org