You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/07/18 12:27:21 UTC

Review Request 50131: LENS-1217: Remove old java ui server

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-1217
    https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
-------


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
  lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
-----------------------------------------------------------

(Updated July 22, 2016, 4:22 p.m.)


Review request for lens.


Bugs: LENS-1217
    https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
  lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
-----------------------------------------------------------

(Updated July 22, 2016, 4:21 p.m.)


Review request for lens.


Bugs: LENS-1217
    https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
  lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
-----------------------------------------------------------

(Updated July 21, 2016, 7:02 p.m.)


Review request for lens.


Bugs: LENS-1217
    https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
  lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/#review143061
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On July 21, 2016, 8:01 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50131/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 8:01 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1217
>     https://issues.apache.org/jira/browse/LENS-1217
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
>   lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
>   lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
>   lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
>   lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
>   lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
>   lens-server/src/main/resources/lensserver-default.xml 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
>   lens-server/src/test/java/org/apache/lens/server/TestLensServer.java eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
>   lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
>   lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 
> 
> Diff: https://reviews.apache.org/r/50131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/
-----------------------------------------------------------

(Updated July 21, 2016, 1:31 p.m.)


Review request for lens.


Bugs: LENS-1217
    https://issues.apache.org/jira/browse/LENS-1217


Repository: lens


Description
-------


Diffs (updated)
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java bd9b1ab020b69d7f8b5b2f8ef5675995ef3b36f3 
  lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
  lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
  lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
  lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
  lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
  lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
  lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
  lens-server/src/main/resources/lensserver-default.xml 3ce8fc1f12b279745d083b8249e942bb7dd6653a 
  lens-server/src/test/java/org/apache/lens/server/TestLensServer.java eb27f61f5f7e09993e5fd9a27695f07683fa7dff 
  lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
  lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 

Diff: https://reviews.apache.org/r/50131/diff/


Testing
-------


Thanks,

Rajat Khandelwal


Re: Review Request 50131: LENS-1217: Remove old java ui server

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50131/#review142718
-----------------------------------------------------------




lens-server/src/main/java/org/apache/lens/server/LensServer.java 
<https://reviews.apache.org/r/50131/#comment208360>

    Remove the config from lensserver-default.xml and LensConfConstants as well.


- Amareshwari Sriramadasu


On July 18, 2016, 12:27 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50131/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 12:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1217
>     https://issues.apache.org/jira/browse/LENS-1217
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/LensServer.java b6983f4c78a9a48c2503560b529663622a3efc36 
>   lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669d75a6aca25c8fdf9af1268758dbe7de38 
>   lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java 27388a7503508b26bdecf5266c98e4cbcc7a94a8 
>   lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java 304dc8efad8bd27c88b58b6ca319dfedcd4ac239 
>   lens-server/src/main/java/org/apache/lens/server/ui/SessionUIResource.java 37bf094347955c5a211299d4367a20bb38dfbc08 
>   lens-server/src/main/java/org/apache/lens/server/ui/StaticFileResource.java 7e0758975cc4d991c24a1df963095d38189f5622 
>   lens-server/src/main/java/org/apache/lens/server/ui/UIApp.java de4ce333082fb80cd0dd7cf64848ddc415336a9e 
>   lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java f8c5bf28457074072d70fdb742b0300380f0679c 
>   lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java aa2874779d4d9e469f124aa9646a02742e2c4960 
> 
> Diff: https://reviews.apache.org/r/50131/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>