You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@ofbiz.apache.org by Rashko Rejmer <rr...@iguanait.com> on 2008/07/01 12:03:53 UTC
Re: Problem with tax recalculation after order item cancellation
Hi Scott and all,
Sorry for the late reply. Comments inline:
On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > The status of the item is set to ITEM_CANCELLED and tax adjustments
> are
> > not removed. Instead of this it is created order header adjustment
> that
> > compensates order item sales tax adjustments. This was introduced in
> > OFBIZ-461. The reason was that it was not possible to remove
> > OrderAdjustment if one part of the adjustment is already
> > invoiced(OrderAdjustmentBilling is present).
>
>
> Instead of creating these balancing adjustments wouldn't it be ok to
> just
> update the OrderAdjustment with the new tax amount?
I was wandering if it is not better to exclude all adjustments(tax,
promotional) of fully canceled order items, from all order amount
calculation methods (getOrderSubTotal, getOrderTotal, ...). This way the
canceled items will be present in the order, only to keep history of
order changes, and they will not be taken into account in all order
amount calculations.
In this case there would not be necessary to create any balancing
adjustments at all.
Regards,
Rashko Rejmer
Re: Problem with tax recalculation after order item cancellation
Posted by Jacopo Cappellato <ja...@gmail.com>.
yes, I agree: we cannot cancel items that have been invoiced.
Jacopo
On Jul 1, 2008, at 1:13 PM, Rashko Rejmer wrote:
> Yes it is possible. I just have created an example on the demo server:
> https://demo.hotwaxmedia.com/ordermgr/control/orderview?orderId=WSCO10002
>
> Maybe this should be deprecated. Probably it will be better, to make
> the
> service to check if part of the item is already shipped and to allow
> only the rest of the item quantity to be canceled.
>
> Regards,
> Rashko Rejmer
>
>
> On Tue, 2008-07-01 at 23:02 +1200, Scott Gray wrote:
>> Is it possible to cancel an order item when part of it has already
>> been
>> shipped?
>>
>> -Scott
>>
>> 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
>>
>>> Thanks Scott,
>>>
>>> I will create Jira for this issue. I also think that the easiest way
>>> will be to delete existing adjustments when canceling order item.
>>> But I
>>> will stick only to changing the amount of all adjustments of the
>>> item to
>>> 0 because in situations when only part of the item is already
>>> shipped
>>> then there will be problems because of existing
>>> OrderAdjustmentBilling
>>> records.
>>> Do you think that this approach could be applied to promotional and
>>> shipping(if any) adjustments of the canceled order items?
>>>
>>> Regards,
>>> Rashko Rejmer
>>>
>>> On Tue, 2008-07-01 at 22:22 +1200, Scott Gray wrote:
>>>> Hi Rashko
>>>>
>>>> I still think it would be easier to either delete the adjustment or
>>> change
>>>> the amount as necessary, mostly because it sounds like the
>>>> easiest fix
>>> and I
>>>> can't think of any reason why the original values would need to be
>>>> maintained. If there's a good reason to keep them then that's
>>>> fine, I
>>> just
>>>> can't think of it.
>>>>
>>>> Regards
>>>> Scott
>>>>
>>>> 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
>>>>
>>>>> Hi Scott and all,
>>>>>
>>>>> Sorry for the late reply. Comments inline:
>>>>>
>>>>> On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
>>>>>>> The status of the item is set to ITEM_CANCELLED and tax
>>>>>>> adjustments
>>>>>> are
>>>>>>> not removed. Instead of this it is created order header
>>>>>>> adjustment
>>>>>> that
>>>>>>> compensates order item sales tax adjustments. This was
>>>>>>> introduced
>>> in
>>>>>>> OFBIZ-461. The reason was that it was not possible to remove
>>>>>>> OrderAdjustment if one part of the adjustment is already
>>>>>>> invoiced(OrderAdjustmentBilling is present).
>>>>>>
>>>>>>
>>>>>> Instead of creating these balancing adjustments wouldn't it be
>>>>>> ok to
>>>>>> just
>>>>>> update the OrderAdjustment with the new tax amount?
>>>>>
>>>>> I was wandering if it is not better to exclude all
>>>>> adjustments(tax,
>>>>> promotional) of fully canceled order items, from all order amount
>>>>> calculation methods (getOrderSubTotal, getOrderTotal, ...). This
>>>>> way
>>> the
>>>>> canceled items will be present in the order, only to keep
>>>>> history of
>>>>> order changes, and they will not be taken into account in all
>>>>> order
>>>>> amount calculations.
>>>>>
>>>>> In this case there would not be necessary to create any balancing
>>>>> adjustments at all.
>>>>>
>>>>> Regards,
>>>>> Rashko Rejmer
>>>>>
>>>>>
>>>
>>>
>
Re: Problem with tax recalculation after order item cancellation
Posted by Scott Gray <le...@gmail.com>.
ugh that looks so wrong, it should be marked as completed, the line total
shouldn't say zero, the adjustments should be updated and
remaining/outstanding quantities shouldn't say -5.
-Scott
2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> Yes it is possible. I just have created an example on the demo server:
> https://demo.hotwaxmedia.com/ordermgr/control/orderview?orderId=WSCO10002
>
> Maybe this should be deprecated. Probably it will be better, to make the
> service to check if part of the item is already shipped and to allow
> only the rest of the item quantity to be canceled.
>
> Regards,
> Rashko Rejmer
>
>
> On Tue, 2008-07-01 at 23:02 +1200, Scott Gray wrote:
> > Is it possible to cancel an order item when part of it has already been
> > shipped?
> >
> > -Scott
> >
> > 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> >
> > > Thanks Scott,
> > >
> > > I will create Jira for this issue. I also think that the easiest way
> > > will be to delete existing adjustments when canceling order item. But I
> > > will stick only to changing the amount of all adjustments of the item
> to
> > > 0 because in situations when only part of the item is already shipped
> > > then there will be problems because of existing OrderAdjustmentBilling
> > > records.
> > > Do you think that this approach could be applied to promotional and
> > > shipping(if any) adjustments of the canceled order items?
> > >
> > > Regards,
> > > Rashko Rejmer
> > >
> > > On Tue, 2008-07-01 at 22:22 +1200, Scott Gray wrote:
> > > > Hi Rashko
> > > >
> > > > I still think it would be easier to either delete the adjustment or
> > > change
> > > > the amount as necessary, mostly because it sounds like the easiest
> fix
> > > and I
> > > > can't think of any reason why the original values would need to be
> > > > maintained. If there's a good reason to keep them then that's fine,
> I
> > > just
> > > > can't think of it.
> > > >
> > > > Regards
> > > > Scott
> > > >
> > > > 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> > > >
> > > > > Hi Scott and all,
> > > > >
> > > > > Sorry for the late reply. Comments inline:
> > > > >
> > > > > On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > > > > > > The status of the item is set to ITEM_CANCELLED and tax
> adjustments
> > > > > > are
> > > > > > > not removed. Instead of this it is created order header
> adjustment
> > > > > > that
> > > > > > > compensates order item sales tax adjustments. This was
> introduced
> > > in
> > > > > > > OFBIZ-461. The reason was that it was not possible to remove
> > > > > > > OrderAdjustment if one part of the adjustment is already
> > > > > > > invoiced(OrderAdjustmentBilling is present).
> > > > > >
> > > > > >
> > > > > > Instead of creating these balancing adjustments wouldn't it be ok
> to
> > > > > > just
> > > > > > update the OrderAdjustment with the new tax amount?
> > > > >
> > > > > I was wandering if it is not better to exclude all adjustments(tax,
> > > > > promotional) of fully canceled order items, from all order amount
> > > > > calculation methods (getOrderSubTotal, getOrderTotal, ...). This
> way
> > > the
> > > > > canceled items will be present in the order, only to keep history
> of
> > > > > order changes, and they will not be taken into account in all order
> > > > > amount calculations.
> > > > >
> > > > > In this case there would not be necessary to create any balancing
> > > > > adjustments at all.
> > > > >
> > > > > Regards,
> > > > > Rashko Rejmer
> > > > >
> > > > >
> > >
> > >
>
>
Re: Problem with tax recalculation after order item cancellation
Posted by Rashko Rejmer <rr...@iguanait.com>.
Yes it is possible. I just have created an example on the demo server:
https://demo.hotwaxmedia.com/ordermgr/control/orderview?orderId=WSCO10002
Maybe this should be deprecated. Probably it will be better, to make the
service to check if part of the item is already shipped and to allow
only the rest of the item quantity to be canceled.
Regards,
Rashko Rejmer
On Tue, 2008-07-01 at 23:02 +1200, Scott Gray wrote:
> Is it possible to cancel an order item when part of it has already been
> shipped?
>
> -Scott
>
> 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
>
> > Thanks Scott,
> >
> > I will create Jira for this issue. I also think that the easiest way
> > will be to delete existing adjustments when canceling order item. But I
> > will stick only to changing the amount of all adjustments of the item to
> > 0 because in situations when only part of the item is already shipped
> > then there will be problems because of existing OrderAdjustmentBilling
> > records.
> > Do you think that this approach could be applied to promotional and
> > shipping(if any) adjustments of the canceled order items?
> >
> > Regards,
> > Rashko Rejmer
> >
> > On Tue, 2008-07-01 at 22:22 +1200, Scott Gray wrote:
> > > Hi Rashko
> > >
> > > I still think it would be easier to either delete the adjustment or
> > change
> > > the amount as necessary, mostly because it sounds like the easiest fix
> > and I
> > > can't think of any reason why the original values would need to be
> > > maintained. If there's a good reason to keep them then that's fine, I
> > just
> > > can't think of it.
> > >
> > > Regards
> > > Scott
> > >
> > > 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> > >
> > > > Hi Scott and all,
> > > >
> > > > Sorry for the late reply. Comments inline:
> > > >
> > > > On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > > > > > The status of the item is set to ITEM_CANCELLED and tax adjustments
> > > > > are
> > > > > > not removed. Instead of this it is created order header adjustment
> > > > > that
> > > > > > compensates order item sales tax adjustments. This was introduced
> > in
> > > > > > OFBIZ-461. The reason was that it was not possible to remove
> > > > > > OrderAdjustment if one part of the adjustment is already
> > > > > > invoiced(OrderAdjustmentBilling is present).
> > > > >
> > > > >
> > > > > Instead of creating these balancing adjustments wouldn't it be ok to
> > > > > just
> > > > > update the OrderAdjustment with the new tax amount?
> > > >
> > > > I was wandering if it is not better to exclude all adjustments(tax,
> > > > promotional) of fully canceled order items, from all order amount
> > > > calculation methods (getOrderSubTotal, getOrderTotal, ...). This way
> > the
> > > > canceled items will be present in the order, only to keep history of
> > > > order changes, and they will not be taken into account in all order
> > > > amount calculations.
> > > >
> > > > In this case there would not be necessary to create any balancing
> > > > adjustments at all.
> > > >
> > > > Regards,
> > > > Rashko Rejmer
> > > >
> > > >
> >
> >
Re: Problem with tax recalculation after order item cancellation
Posted by Scott Gray <le...@gmail.com>.
Is it possible to cancel an order item when part of it has already been
shipped?
-Scott
2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> Thanks Scott,
>
> I will create Jira for this issue. I also think that the easiest way
> will be to delete existing adjustments when canceling order item. But I
> will stick only to changing the amount of all adjustments of the item to
> 0 because in situations when only part of the item is already shipped
> then there will be problems because of existing OrderAdjustmentBilling
> records.
> Do you think that this approach could be applied to promotional and
> shipping(if any) adjustments of the canceled order items?
>
> Regards,
> Rashko Rejmer
>
> On Tue, 2008-07-01 at 22:22 +1200, Scott Gray wrote:
> > Hi Rashko
> >
> > I still think it would be easier to either delete the adjustment or
> change
> > the amount as necessary, mostly because it sounds like the easiest fix
> and I
> > can't think of any reason why the original values would need to be
> > maintained. If there's a good reason to keep them then that's fine, I
> just
> > can't think of it.
> >
> > Regards
> > Scott
> >
> > 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> >
> > > Hi Scott and all,
> > >
> > > Sorry for the late reply. Comments inline:
> > >
> > > On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > > > > The status of the item is set to ITEM_CANCELLED and tax adjustments
> > > > are
> > > > > not removed. Instead of this it is created order header adjustment
> > > > that
> > > > > compensates order item sales tax adjustments. This was introduced
> in
> > > > > OFBIZ-461. The reason was that it was not possible to remove
> > > > > OrderAdjustment if one part of the adjustment is already
> > > > > invoiced(OrderAdjustmentBilling is present).
> > > >
> > > >
> > > > Instead of creating these balancing adjustments wouldn't it be ok to
> > > > just
> > > > update the OrderAdjustment with the new tax amount?
> > >
> > > I was wandering if it is not better to exclude all adjustments(tax,
> > > promotional) of fully canceled order items, from all order amount
> > > calculation methods (getOrderSubTotal, getOrderTotal, ...). This way
> the
> > > canceled items will be present in the order, only to keep history of
> > > order changes, and they will not be taken into account in all order
> > > amount calculations.
> > >
> > > In this case there would not be necessary to create any balancing
> > > adjustments at all.
> > >
> > > Regards,
> > > Rashko Rejmer
> > >
> > >
>
>
Re: Problem with tax recalculation after order item cancellation
Posted by Rashko Rejmer <rr...@iguanait.com>.
Thanks Scott,
I will create Jira for this issue. I also think that the easiest way
will be to delete existing adjustments when canceling order item. But I
will stick only to changing the amount of all adjustments of the item to
0 because in situations when only part of the item is already shipped
then there will be problems because of existing OrderAdjustmentBilling
records.
Do you think that this approach could be applied to promotional and
shipping(if any) adjustments of the canceled order items?
Regards,
Rashko Rejmer
On Tue, 2008-07-01 at 22:22 +1200, Scott Gray wrote:
> Hi Rashko
>
> I still think it would be easier to either delete the adjustment or change
> the amount as necessary, mostly because it sounds like the easiest fix and I
> can't think of any reason why the original values would need to be
> maintained. If there's a good reason to keep them then that's fine, I just
> can't think of it.
>
> Regards
> Scott
>
> 2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
>
> > Hi Scott and all,
> >
> > Sorry for the late reply. Comments inline:
> >
> > On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > > > The status of the item is set to ITEM_CANCELLED and tax adjustments
> > > are
> > > > not removed. Instead of this it is created order header adjustment
> > > that
> > > > compensates order item sales tax adjustments. This was introduced in
> > > > OFBIZ-461. The reason was that it was not possible to remove
> > > > OrderAdjustment if one part of the adjustment is already
> > > > invoiced(OrderAdjustmentBilling is present).
> > >
> > >
> > > Instead of creating these balancing adjustments wouldn't it be ok to
> > > just
> > > update the OrderAdjustment with the new tax amount?
> >
> > I was wandering if it is not better to exclude all adjustments(tax,
> > promotional) of fully canceled order items, from all order amount
> > calculation methods (getOrderSubTotal, getOrderTotal, ...). This way the
> > canceled items will be present in the order, only to keep history of
> > order changes, and they will not be taken into account in all order
> > amount calculations.
> >
> > In this case there would not be necessary to create any balancing
> > adjustments at all.
> >
> > Regards,
> > Rashko Rejmer
> >
> >
Re: Problem with tax recalculation after order item cancellation
Posted by Scott Gray <le...@gmail.com>.
Hi Rashko
I still think it would be easier to either delete the adjustment or change
the amount as necessary, mostly because it sounds like the easiest fix and I
can't think of any reason why the original values would need to be
maintained. If there's a good reason to keep them then that's fine, I just
can't think of it.
Regards
Scott
2008/7/1 Rashko Rejmer <rr...@iguanait.com>:
> Hi Scott and all,
>
> Sorry for the late reply. Comments inline:
>
> On Wed, 2008-06-25 at 23:01 +1200, Scott Gray wrote:
> > > The status of the item is set to ITEM_CANCELLED and tax adjustments
> > are
> > > not removed. Instead of this it is created order header adjustment
> > that
> > > compensates order item sales tax adjustments. This was introduced in
> > > OFBIZ-461. The reason was that it was not possible to remove
> > > OrderAdjustment if one part of the adjustment is already
> > > invoiced(OrderAdjustmentBilling is present).
> >
> >
> > Instead of creating these balancing adjustments wouldn't it be ok to
> > just
> > update the OrderAdjustment with the new tax amount?
>
> I was wandering if it is not better to exclude all adjustments(tax,
> promotional) of fully canceled order items, from all order amount
> calculation methods (getOrderSubTotal, getOrderTotal, ...). This way the
> canceled items will be present in the order, only to keep history of
> order changes, and they will not be taken into account in all order
> amount calculations.
>
> In this case there would not be necessary to create any balancing
> adjustments at all.
>
> Regards,
> Rashko Rejmer
>
>