You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ch...@apache.org on 2025/07/23 13:37:55 UTC

(kafka) branch trunk updated: MINOR: Declare the inner RocksDBDualCFRangeIterator class as static (#20220)

This is an automated email from the ASF dual-hosted git repository.

chia7712 pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 0086f241013 MINOR: Declare the inner RocksDBDualCFRangeIterator class as static (#20220)
0086f241013 is described below

commit 0086f241013245a0fba70921d6154929cab1f805
Author: Chang-Chi Hsu <47...@users.noreply.github.com>
AuthorDate: Wed Jul 23 21:37:48 2025 +0800

    MINOR: Declare the inner RocksDBDualCFRangeIterator class as static (#20220)
    
    Make inner classes static.
    
    from: https://github.com/apache/kafka/pull/20182#issuecomment-3102893453
    
    Reviewers: Ken Huang <s7...@gmail.com>, Chia-Ping Tsai
    <ch...@gmail.com>
---
 .../apache/kafka/streams/state/internals/RocksDBTimestampedStore.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
index 76ff9f71f6f..7c44ca7c179 100644
--- a/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
+++ b/streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java
@@ -404,7 +404,7 @@ public class RocksDBTimestampedStore extends RocksDBStore implements Timestamped
         }
     }
 
-    private class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {
+    private static class RocksDBDualCFRangeIterator extends RocksDBDualCFIterator {
         // RocksDB's JNI interface does not expose getters/setters that allow the
         // comparator to be pluggable, and the default is lexicographic, so it's
         // safe to just force lexicographic comparator here for now.