You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Damien Diederen (Jira)" <ji...@apache.org> on 2021/03/06 18:09:00 UTC
[jira] [Created] (ZOOKEEPER-4232) InvalidSnapshotTest corrupts its
own test data
Damien Diederen created ZOOKEEPER-4232:
------------------------------------------
Summary: InvalidSnapshotTest corrupts its own test data
Key: ZOOKEEPER-4232
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-4232
Project: ZooKeeper
Issue Type: Bug
Reporter: Damien Diederen
Assignee: Damien Diederen
{{InvalidSnapshotTest.testSnapshot}} starts an instance of {{ZooKeeperServer}} on the version-controlled {{invalidsnap}} directory, which, as a side-effect, "fixes" the following snapshot—which is broken on purpose (see ZOOKEEPER-367):
{{zookeeper-server/src/test/resources/data/invalidsnap/version-2/snapshot.83f}}
This status quo creates a number of problems:
# It makes the test ineffective after the first run;
# The file shows as modified in version control tools, which can be annoying;
# The "fixed" snapshot can end up being committed by mistake, invalidating the test.
(#3 is not theoretical; that "fixed" snapshot frequently shows up in pull requests, and was recently merged into master.).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)