You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "AkashBoora (via GitHub)" <gi...@apache.org> on 2023/03/23 08:56:50 UTC
[GitHub] [superset] AkashBoora opened a new pull request, #23469: fix(area chart legacy): tool tip shows actual value rather than y axi…
AkashBoora opened a new pull request, #23469:
URL: https://github.com/apache/superset/pull/23469
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
Tha area chart was showing the decimal values when it is expanded mode rather than actula values. I made changes so that it gonna show the actual value rather than decimal values (these decimal values were representing the percentage of value w.r.t total)
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: https://github.com/apache/superset/issues/20003
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #23469: fix(area chart legacy): tool tip shows actual value rather than y axi…
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #23469:
URL: https://github.com/apache/superset/pull/23469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23469: fix(area chart legacy): tool tip shows actual value rather than y axi…
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23469:
URL: https://github.com/apache/superset/pull/23469#issuecomment-1480896706
## [Codecov](https://codecov.io/gh/apache/superset/pull/23469?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23469](https://codecov.io/gh/apache/superset/pull/23469?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (efd206f) into [master](https://codecov.io/gh/apache/superset/commit/212b7330d6643b4c4e7d5e3b81279822d4618c01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (212b733) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head efd206f differs from pull request most recent head a9dec12. Consider uploading reports for the commit a9dec12 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23469 +/- ##
=======================================
Coverage 67.64% 67.64%
=======================================
Files 1908 1908
Lines 73739 73739
Branches 7988 7988
=======================================
Hits 49879 49879
Misses 21814 21814
Partials 2046 2046
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.82% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tend/plugins/legacy-preset-chart-nvd3/src/utils.js](https://codecov.io/gh/apache/superset/pull/23469?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3V0aWxzLmpz) | `15.92% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org